[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Enable dynamic DPTF

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/23462


Change subject: soc/intel/skylake: Enable dynamic DPTF
......................................................................

soc/intel/skylake: Enable dynamic DPTF

This change adds support for:
1. Handling thermal trip points change event handler based on device
mode.
2. Returning thermal trip point temperatures based on the device mode.

BUG=b:72554519

Change-Id: Ife48af76ceb7a39abd1fac8ef1f77db7e65ab43e
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/soc/intel/skylake/acpi/dptf/thermal.asl
1 file changed, 71 insertions(+), 8 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/23462/1

diff --git a/src/soc/intel/skylake/acpi/dptf/thermal.asl b/src/soc/intel/skylake/acpi/dptf/thermal.asl
index a94c278..114067f 100644
--- a/src/soc/intel/skylake/acpi/dptf/thermal.asl
+++ b/src/soc/intel/skylake/acpi/dptf/thermal.asl
@@ -57,7 +57,46 @@
 #endif
 }
 
+/* Thermal Trip Points Change Event Handler */
+Method (TPET)
+{
 #ifdef DPTF_TSR0_SENSOR_ID
+	Notify (^TSR0, 0x81)
+#endif
+#ifdef DPTF_TSR1_SENSOR_ID
+	Notify (^TSR1, 0x81)
+#endif
+#ifdef DPTF_TSR2_SENSOR_ID
+	Notify (^TSR2, 0x81)
+#endif
+#ifdef DPTF_TSR3_SENSOR_ID
+	Notify (^TSR3, 0x81)
+#endif
+}
+
+/*
+ * Method to return trip temperature value depending upon the device mode.
+ * Arg0 --> Value to return when device is in tablet mode
+ * Arg1 --> Value to return when device is not in tablet mode.
+ */
+Method (DTRP, 2, Serialized)
+{
+	If (LEqual (\_SB.PCI0.LPCB.EC0.RCTM, One)) {
+		Return (CTOK (Arg0))
+	} Else {
+		Return (CTOK (Arg1))
+	}
+}
+
+#ifdef DPTF_TSR0_SENSOR_ID
+
+#ifndef DPTF_TSR0_TABLET_PASSIVE
+#define DPTF_TSR0_TABLET_PASSIVE DPTF_TSR0_PASSIVE
+#endif
+#ifndef DPTF_TSR0_TABLET_CRITICAL
+#define DPTF_TSR0_TABLET_CRITICAL DPTF_TSR0_CRITICAL
+#endif
+
 Device (TSR0)
 {
 	Name (_HID, EISAID ("INT3403"))
@@ -83,12 +122,12 @@
 
 	Method (_PSV)
 	{
-		Return (CTOK (DPTF_TSR0_PASSIVE))
+		Return (DTRP (DPTF_TSR0_TABLET_PASSIVE, DPTF_TSR0_PASSIVE))
 	}
 
 	Method (_CRT)
 	{
-		Return (CTOK (DPTF_TSR0_CRITICAL))
+		Return (DTRP (DPTF_TSR0_TABLET_CRITICAL, DPTF_TSR0_CRITICAL))
 	}
 
 	Name (PATC, 2)
@@ -151,6 +190,14 @@
 #endif
 
 #ifdef DPTF_TSR1_SENSOR_ID
+
+#ifndef DPTF_TSR1_TABLET_PASSIVE
+#define DPTF_TSR1_TABLET_PASSIVE DPTF_TSR1_PASSIVE
+#endif
+#ifndef DPTF_TSR1_TABLET_CRITICAL
+#define DPTF_TSR1_TABLET_CRITICAL DPTF_TSR1_CRITICAL
+#endif
+
 Device (TSR1)
 {
 	Name (_HID, EISAID ("INT3403"))
@@ -176,12 +223,12 @@
 
 	Method (_PSV)
 	{
-		Return (CTOK (DPTF_TSR1_PASSIVE))
+		Return (DTRP (DPTF_TSR1_TABLET_PASSIVE, DPTF_TSR1_PASSIVE))
 	}
 
 	Method (_CRT)
 	{
-		Return (CTOK (DPTF_TSR1_CRITICAL))
+		Return (DTRP (DPTF_TSR1_TABLET_CRITICAL, DPTF_TSR1_CRITICAL))
 	}
 
 	Name (PATC, 2)
@@ -207,6 +254,14 @@
 #endif
 
 #ifdef DPTF_TSR2_SENSOR_ID
+
+#ifndef DPTF_TSR2_TABLET_PASSIVE
+#define DPTF_TSR2_TABLET_PASSIVE DPTF_TSR2_PASSIVE
+#endif
+#ifndef DPTF_TSR2_TABLET_CRITICAL
+#define DPTF_TSR2_TABLET_CRITICAL DPTF_TSR2_CRITICAL
+#endif
+
 Device (TSR2)
 {
 	Name (_HID, EISAID ("INT3403"))
@@ -232,12 +287,12 @@
 
 	Method (_PSV)
 	{
-		Return (CTOK (DPTF_TSR2_PASSIVE))
+		Return (DTRP (DPTF_TSR2_TABLET_PASSIVE, DPTF_TSR2_PASSIVE))
 	}
 
 	Method (_CRT)
 	{
-		Return (CTOK (DPTF_TSR2_CRITICAL))
+		Return (DTRP (DPTF_TSR2_TABLET_CRITICAL, DPTF_TSR2_CRITICAL))
 	}
 
 	Name (PATC, 2)
@@ -263,6 +318,14 @@
 #endif
 
 #ifdef DPTF_TSR3_SENSOR_ID
+
+#ifndef DPTF_TSR3_TABLET_PASSIVE
+#define DPTF_TSR3_TABLET_PASSIVE DPTF_TSR3_PASSIVE
+#endif
+#ifndef DPTF_TSR3_TABLET_CRITICAL
+#define DPTF_TSR3_TABLET_CRITICAL DPTF_TSR3_CRITICAL
+#endif
+
 Device (TSR3)
 {
 	Name (_HID, EISAID ("INT3403"))
@@ -288,12 +351,12 @@
 
 	Method (_PSV)
 	{
-		Return (CTOK (DPTF_TSR3_PASSIVE))
+		Return (DTRP (DPTF_TSR3_TABLET_PASSIVE, DPTF_TSR3_PASSIVE))
 	}
 
 	Method (_CRT)
 	{
-		Return (CTOK (DPTF_TSR3_CRITICAL))
+		Return (DTRP (DPTF_TSR3_TABLET_CRITICAL, DPTF_TSR3_CRITICAL))
 	}
 
 	Name (PATC, 2)

-- 
To view, visit https://review.coreboot.org/23462
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife48af76ceb7a39abd1fac8ef1f77db7e65ab43e
Gerrit-Change-Number: 23462
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180127/a5441fe3/attachment-0001.html>