<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23462">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/skylake: Enable dynamic DPTF<br><br>This change adds support for:<br>1. Handling thermal trip points change event handler based on device<br>mode.<br>2. Returning thermal trip point temperatures based on the device mode.<br><br>BUG=b:72554519<br><br>Change-Id: Ife48af76ceb7a39abd1fac8ef1f77db7e65ab43e<br>Signed-off-by: Furquan Shaikh <furquan@chromium.org><br>---<br>M src/soc/intel/skylake/acpi/dptf/thermal.asl<br>1 file changed, 71 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/23462/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/skylake/acpi/dptf/thermal.asl b/src/soc/intel/skylake/acpi/dptf/thermal.asl</span><br><span>index a94c278..114067f 100644</span><br><span>--- a/src/soc/intel/skylake/acpi/dptf/thermal.asl</span><br><span>+++ b/src/soc/intel/skylake/acpi/dptf/thermal.asl</span><br><span>@@ -57,7 +57,46 @@</span><br><span> #endif</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Thermal Trip Points Change Event Handler */</span><br><span style="color: hsl(120, 100%, 40%);">+Method (TPET)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span> #ifdef DPTF_TSR0_SENSOR_ID</span><br><span style="color: hsl(120, 100%, 40%);">+ Notify (^TSR0, 0x81)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef DPTF_TSR1_SENSOR_ID</span><br><span style="color: hsl(120, 100%, 40%);">+ Notify (^TSR1, 0x81)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef DPTF_TSR2_SENSOR_ID</span><br><span style="color: hsl(120, 100%, 40%);">+ Notify (^TSR2, 0x81)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef DPTF_TSR3_SENSOR_ID</span><br><span style="color: hsl(120, 100%, 40%);">+ Notify (^TSR3, 0x81)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Method to return trip temperature value depending upon the device mode.</span><br><span style="color: hsl(120, 100%, 40%);">+ * Arg0 --> Value to return when device is in tablet mode</span><br><span style="color: hsl(120, 100%, 40%);">+ * Arg1 --> Value to return when device is not in tablet mode.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+Method (DTRP, 2, Serialized)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ If (LEqual (\_SB.PCI0.LPCB.EC0.RCTM, One)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (CTOK (Arg0))</span><br><span style="color: hsl(120, 100%, 40%);">+ } Else {</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (CTOK (Arg1))</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#ifdef DPTF_TSR0_SENSOR_ID</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef DPTF_TSR0_TABLET_PASSIVE</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR0_TABLET_PASSIVE DPTF_TSR0_PASSIVE</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef DPTF_TSR0_TABLET_CRITICAL</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR0_TABLET_CRITICAL DPTF_TSR0_CRITICAL</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> Device (TSR0)</span><br><span> {</span><br><span> Name (_HID, EISAID ("INT3403"))</span><br><span>@@ -83,12 +122,12 @@</span><br><span> </span><br><span> Method (_PSV)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (CTOK (DPTF_TSR0_PASSIVE))</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (DTRP (DPTF_TSR0_TABLET_PASSIVE, DPTF_TSR0_PASSIVE))</span><br><span> }</span><br><span> </span><br><span> Method (_CRT)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (CTOK (DPTF_TSR0_CRITICAL))</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (DTRP (DPTF_TSR0_TABLET_CRITICAL, DPTF_TSR0_CRITICAL))</span><br><span> }</span><br><span> </span><br><span> Name (PATC, 2)</span><br><span>@@ -151,6 +190,14 @@</span><br><span> #endif</span><br><span> </span><br><span> #ifdef DPTF_TSR1_SENSOR_ID</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef DPTF_TSR1_TABLET_PASSIVE</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR1_TABLET_PASSIVE DPTF_TSR1_PASSIVE</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef DPTF_TSR1_TABLET_CRITICAL</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR1_TABLET_CRITICAL DPTF_TSR1_CRITICAL</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> Device (TSR1)</span><br><span> {</span><br><span> Name (_HID, EISAID ("INT3403"))</span><br><span>@@ -176,12 +223,12 @@</span><br><span> </span><br><span> Method (_PSV)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (CTOK (DPTF_TSR1_PASSIVE))</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (DTRP (DPTF_TSR1_TABLET_PASSIVE, DPTF_TSR1_PASSIVE))</span><br><span> }</span><br><span> </span><br><span> Method (_CRT)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (CTOK (DPTF_TSR1_CRITICAL))</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (DTRP (DPTF_TSR1_TABLET_CRITICAL, DPTF_TSR1_CRITICAL))</span><br><span> }</span><br><span> </span><br><span> Name (PATC, 2)</span><br><span>@@ -207,6 +254,14 @@</span><br><span> #endif</span><br><span> </span><br><span> #ifdef DPTF_TSR2_SENSOR_ID</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef DPTF_TSR2_TABLET_PASSIVE</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR2_TABLET_PASSIVE DPTF_TSR2_PASSIVE</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef DPTF_TSR2_TABLET_CRITICAL</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR2_TABLET_CRITICAL DPTF_TSR2_CRITICAL</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> Device (TSR2)</span><br><span> {</span><br><span> Name (_HID, EISAID ("INT3403"))</span><br><span>@@ -232,12 +287,12 @@</span><br><span> </span><br><span> Method (_PSV)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (CTOK (DPTF_TSR2_PASSIVE))</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (DTRP (DPTF_TSR2_TABLET_PASSIVE, DPTF_TSR2_PASSIVE))</span><br><span> }</span><br><span> </span><br><span> Method (_CRT)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (CTOK (DPTF_TSR2_CRITICAL))</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (DTRP (DPTF_TSR2_TABLET_CRITICAL, DPTF_TSR2_CRITICAL))</span><br><span> }</span><br><span> </span><br><span> Name (PATC, 2)</span><br><span>@@ -263,6 +318,14 @@</span><br><span> #endif</span><br><span> </span><br><span> #ifdef DPTF_TSR3_SENSOR_ID</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef DPTF_TSR3_TABLET_PASSIVE</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR3_TABLET_PASSIVE DPTF_TSR3_PASSIVE</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+#ifndef DPTF_TSR3_TABLET_CRITICAL</span><br><span style="color: hsl(120, 100%, 40%);">+#define DPTF_TSR3_TABLET_CRITICAL DPTF_TSR3_CRITICAL</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> Device (TSR3)</span><br><span> {</span><br><span> Name (_HID, EISAID ("INT3403"))</span><br><span>@@ -288,12 +351,12 @@</span><br><span> </span><br><span> Method (_PSV)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (CTOK (DPTF_TSR3_PASSIVE))</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (DTRP (DPTF_TSR3_TABLET_PASSIVE, DPTF_TSR3_PASSIVE))</span><br><span> }</span><br><span> </span><br><span> Method (_CRT)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- Return (CTOK (DPTF_TSR3_CRITICAL))</span><br><span style="color: hsl(120, 100%, 40%);">+ Return (DTRP (DPTF_TSR3_TABLET_CRITICAL, DPTF_TSR3_CRITICAL))</span><br><span> }</span><br><span> </span><br><span> Name (PATC, 2)</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23462">change 23462</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23462"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Ife48af76ceb7a39abd1fac8ef1f77db7e65ab43e </div>
<div style="display:none"> Gerrit-Change-Number: 23462 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>