[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/soraka: Configure unused pins as NC
Furquan Shaikh (Code Review)
gerrit at coreboot.org
Wed Jan 24 22:19:57 CET 2018
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/23416
Change subject: mb/google/poppy/variants/soraka: Configure unused pins as NC
......................................................................
mb/google/poppy/variants/soraka: Configure unused pins as NC
This change configures unused pins as not connected.
Change-Id: I6779d9fba73da8fb2faa08ad5d2236b813105720
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/mainboard/google/poppy/variants/soraka/gpio.c
1 file changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/23416/1
diff --git a/src/mainboard/google/poppy/variants/soraka/gpio.c b/src/mainboard/google/poppy/variants/soraka/gpio.c
index 50bac4b..0e24bb7 100644
--- a/src/mainboard/google/poppy/variants/soraka/gpio.c
+++ b/src/mainboard/google/poppy/variants/soraka/gpio.c
@@ -127,10 +127,10 @@
PAD_CFG_GPI_GPIO_DRIVER(GPP_C6, 20K_PU, DEEP),
/* C7 : SM1DATA ==> NC */
PAD_CFG_NC(GPP_C7),
- /* C8 : UART0_RXD ==> FP_INT */
- PAD_CFG_GPI_APIC(GPP_C8, NONE, PLTRST),
- /* C9 : UART0_TXD ==> FP_RST_ODL */
- PAD_CFG_GPO(GPP_C9, 0, DEEP),
+ /* C8 : UART0_RXD ==> NC */
+ PAD_CFG_NC(GPP_C8),
+ /* C9 : UART0_TXD ==> NC */
+ PAD_CFG_NC(GPP_C9),
/* C10 : UART0_RTS# ==> EC_CAM_PMIC_RST_L */
PAD_CFG_GPO(GPP_C10, 1, DEEP),
/* C11 : UART0_CTS# ==> EN_PP3300_DX_CAM */
@@ -170,10 +170,10 @@
PAD_CFG_NC(GPP_D3),
/* D4 : FASHTRIG ==> NC */
PAD_CFG_NC(GPP_D4),
- /* D5 : ISH_I2C0_SDA ==> ISH_I2C_SENSOR_1V8_SDA */
- PAD_CFG_NF_1V8(GPP_D5, NONE, DEEP, NF1),
- /* D6 : ISH_I2C0_SCL ==> ISH_I2C_SENSOR_1V8_SCL */
- PAD_CFG_NF_1V8(GPP_D6, NONE, DEEP, NF1),
+ /* D5 : ISH_I2C0_SDA ==> NC */
+ PAD_CFG_NC(GPP_D5),
+ /* D6 : ISH_I2C0_SCL ==> NC */
+ PAD_CFG_NC(GPP_D6),
/* D7 : ISH_I2C1_SDA ==> NC */
PAD_CFG_NC(GPP_D7),
/* D8 : ISH_I2C1_SCL ==> NC */
@@ -258,7 +258,7 @@
/* E23 : DDPD_CTRLDATA ==> NC */
PAD_CFG_NC(GPP_E23),
- /* The next 4 pads are for bit banging the amplifiers, default to I2S */
+ /* The next 3 pads are for bit banging the amplifiers, default to I2S */
/* F0 : I2S2_SCLK ==> I2S2_SCLK_SPKR_R */
PAD_CFG_GPI_GPIO_DRIVER(GPP_F0, NONE, DEEP),
/* F1 : I2S2_SFRM ==> I2S2_SFRM_SPKR_R */
--
To view, visit https://review.coreboot.org/23416
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6779d9fba73da8fb2faa08ad5d2236b813105720
Gerrit-Change-Number: 23416
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180124/31cac3d5/attachment.html>
More information about the coreboot-gerrit
mailing list