[coreboot-gerrit] Change in coreboot[master]: drivers/intel/fsp2_0: Make use of Resource Type macro from EDK code

Subrata Banik (Code Review) gerrit at coreboot.org
Mon Jan 22 12:13:19 CET 2018


Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/23356


Change subject: drivers/intel/fsp2_0: Make use of Resource Type macro from EDK code
......................................................................

drivers/intel/fsp2_0: Make use of Resource Type macro from EDK code

Users are getting build error due to duplicate macro definitions
of same resource type between fsp driver code and UEFI headers.

Hence this patch ensures to refer a single source location for
macro definitions to avoid compilation error.

Change-Id: If022eb29550a9310b095bff6130b02fb0a25ef7a
Signed-off-by: Subrata Banik <subrata.banik at intel.com>
---
M src/drivers/intel/fsp2_0/include/fsp/util.h
1 file changed, 1 insertion(+), 11 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/23356/1

diff --git a/src/drivers/intel/fsp2_0/include/fsp/util.h b/src/drivers/intel/fsp2_0/include/fsp/util.h
index 6d53fda..b52a3da 100644
--- a/src/drivers/intel/fsp2_0/include/fsp/util.h
+++ b/src/drivers/intel/fsp2_0/include/fsp/util.h
@@ -20,6 +20,7 @@
 #include <fsp/api.h>
 #include <fsp/info_header.h>
 #include <memrange.h>
+#include <Pi/PiHob.h>
 
 struct hob_header {
 	uint16_t type;
@@ -38,17 +39,6 @@
 	uint64_t length;
 } __packed;
 
-enum resource_type {
-	EFI_RESOURCE_SYSTEM_MEMORY		= 0,
-	EFI_RESOURCE_MEMORY_MAPPED_IO		= 1,
-	EFI_RESOURCE_IO				= 2,
-	EFI_RESOURCE_FIRMWARE_DEVICE		= 3,
-	EFI_RESOURCE_MEMORY_MAPPED_IO_PORT	= 4,
-	EFI_RESOURCE_MEMORY_RESERVED		= 5,
-	EFI_RESOURCE_IO_RESERVED		= 6,
-	EFI_RESOURCE_MAX_MEMORY_TYPE		= 7,
-};
-
 enum hob_type {
 	HOB_TYPE_HANDOFF			= 0x0001,
 	HOB_TYPE_MEMORY_ALLOCATION		= 0x0002,

-- 
To view, visit https://review.coreboot.org/23356
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If022eb29550a9310b095bff6130b02fb0a25ef7a
Gerrit-Change-Number: 23356
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180122/c1cb3ead/attachment.html>


More information about the coreboot-gerrit mailing list