<p>Subrata Banik has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23356">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">drivers/intel/fsp2_0: Make use of Resource Type macro from EDK code<br><br>Users are getting build error due to duplicate macro definitions<br>of same resource type between fsp driver code and UEFI headers.<br><br>Hence this patch ensures to refer a single source location for<br>macro definitions to avoid compilation error.<br><br>Change-Id: If022eb29550a9310b095bff6130b02fb0a25ef7a<br>Signed-off-by: Subrata Banik <subrata.banik@intel.com><br>---<br>M src/drivers/intel/fsp2_0/include/fsp/util.h<br>1 file changed, 1 insertion(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/23356/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/drivers/intel/fsp2_0/include/fsp/util.h b/src/drivers/intel/fsp2_0/include/fsp/util.h</span><br><span>index 6d53fda..b52a3da 100644</span><br><span>--- a/src/drivers/intel/fsp2_0/include/fsp/util.h</span><br><span>+++ b/src/drivers/intel/fsp2_0/include/fsp/util.h</span><br><span>@@ -20,6 +20,7 @@</span><br><span> #include <fsp/api.h></span><br><span> #include <fsp/info_header.h></span><br><span> #include <memrange.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <Pi/PiHob.h></span><br><span> </span><br><span> struct hob_header {</span><br><span>   uint16_t type;</span><br><span>@@ -38,17 +39,6 @@</span><br><span>  uint64_t length;</span><br><span> } __packed;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-enum resource_type {</span><br><span style="color: hsl(0, 100%, 40%);">- EFI_RESOURCE_SYSTEM_MEMORY              = 0,</span><br><span style="color: hsl(0, 100%, 40%);">-    EFI_RESOURCE_MEMORY_MAPPED_IO           = 1,</span><br><span style="color: hsl(0, 100%, 40%);">-    EFI_RESOURCE_IO                         = 2,</span><br><span style="color: hsl(0, 100%, 40%);">-    EFI_RESOURCE_FIRMWARE_DEVICE            = 3,</span><br><span style="color: hsl(0, 100%, 40%);">-    EFI_RESOURCE_MEMORY_MAPPED_IO_PORT      = 4,</span><br><span style="color: hsl(0, 100%, 40%);">-    EFI_RESOURCE_MEMORY_RESERVED            = 5,</span><br><span style="color: hsl(0, 100%, 40%);">-    EFI_RESOURCE_IO_RESERVED                = 6,</span><br><span style="color: hsl(0, 100%, 40%);">-    EFI_RESOURCE_MAX_MEMORY_TYPE            = 7,</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> enum hob_type {</span><br><span>    HOB_TYPE_HANDOFF                        = 0x0001,</span><br><span>    HOB_TYPE_MEMORY_ALLOCATION              = 0x0002,</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23356">change 23356</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23356"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: If022eb29550a9310b095bff6130b02fb0a25ef7a </div>
<div style="display:none"> Gerrit-Change-Number: 23356 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Subrata Banik <subrata.banik@intel.com> </div>