[coreboot-gerrit] Change in coreboot[master]: drivers/gpio_keys: Add driver for handling gpio-keys

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/23236 )

Change subject: drivers/gpio_keys: Add driver for handling gpio-keys
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/23236/1/src/drivers/generic/gpio_keys/chip.h
File src/drivers/generic/gpio_keys/chip.h:

https://review.coreboot.org/#/c/23236/1/src/drivers/generic/gpio_keys/chip.h@19
PS1, Line 19: #include <arch/acpi_device.h>
Need to include stdint.h


https://review.coreboot.org/#/c/23236/1/src/drivers/generic/gpio_keys/chip.h@22
PS1, Line 22: const char *dev_name;
            : 	uint32_t linux_code;
            : 	uint32_t linux_input_type;
            : 	const char *label;
            : 	bool is_wakeup_source;
            : 	bool can_be_disabled;
            : 	uint32_t debounce_interval;
            : };
Need to add details about each field.



-- 
To view, visit https://review.coreboot.org/23236
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f11397b17d9de1c87d56f6a61669ef4052ec27b
Gerrit-Change-Number: 23236
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: shkim <sh_.kim at samsung.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 04:10:24 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180112/e3462149/attachment.html>