<p><a href="https://review.coreboot.org/23236">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23236/1/src/drivers/generic/gpio_keys/chip.h">File src/drivers/generic/gpio_keys/chip.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23236/1/src/drivers/generic/gpio_keys/chip.h@19">Patch Set #1, Line 19:</a> <code style="font-family:monospace,monospace">#include <arch/acpi_device.h></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need to include stdint.h</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23236/1/src/drivers/generic/gpio_keys/chip.h@22">Patch Set #1, Line 22:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">const char *dev_name;<br>     uint32_t linux_code;<br>  uint32_t linux_input_type;<br>    const char *label;<br>    bool is_wakeup_source;<br>        bool can_be_disabled;<br> uint32_t debounce_interval;<br>};<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Need to add details about each field.</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/23236">change 23236</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23236"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I6f11397b17d9de1c87d56f6a61669ef4052ec27b </div>
<div style="display:none"> Gerrit-Change-Number: 23236 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: shkim <sh_.kim@samsung.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 12 Jan 2018 04:10:24 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>