[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: Fix GPIO table

[Martin Roth (Code Review)]

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/23224


Change subject: mainboard/google/kahlee: Fix GPIO table
......................................................................

mainboard/google/kahlee: Fix GPIO table

The GPIOS that are being set low had the wrong value getting set.
FCH_GPIO_OUTPUT_VALUE was being set instead of FCH_GPIO_OUTPUT_ENABLE.

BUG=b:70234300
TEST=Build and boot Grunt

Change-Id: I16792b76252506a43aac92738b04096ae3fde01c
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/kahlee/variants/baseboard/gpio.c
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/23224/1

diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
index 250fcc1..58d9473 100644
--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c
+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c
@@ -112,7 +112,7 @@
 	{ GPIO_42, Function0, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE },
 
 	/* GPIO_67 - PEN_RESET */
-	{ GPIO_67, Function0, FCH_GPIO_OUTPUT_VALUE },
+	{ GPIO_67, Function0, FCH_GPIO_OUTPUT_ENABLE },
 
 	/* GPIO_70 - WLAN_PE_RST_L */
 	{ GPIO_70, Function0, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE },
@@ -127,10 +127,10 @@
 	{ GPIO_76, Function0, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE },
 
 	/* GPIO_84 - HUB_RST (Active High) */
-	{ GPIO_84, Function1, FCH_GPIO_OUTPUT_VALUE },
+	{ GPIO_84, Function1, FCH_GPIO_OUTPUT_ENABLE },
 
 	/* GPIO_85 - TOUCHSCREEN_RST (Active High) */
-	{ GPIO_85, Function1, FCH_GPIO_OUTPUT_VALUE },
+	{ GPIO_85, Function1, FCH_GPIO_OUTPUT_ENABLE },
 
 	/* GPIO_86 - Unused (TP109) */
 	{ GPIO_86, Function1, FCH_GPIO_PULL_UP_ENABLE },
@@ -208,7 +208,7 @@
 	{ GPIO_132, Function2,  },
 
 	/* GPIO_133 - APU_EDP_BKLTEN_L (backlight - Active LOW) */
-	{ GPIO_133, Function1, FCH_GPIO_OUTPUT_VALUE },
+	{ GPIO_133, Function1, FCH_GPIO_OUTPUT_ENABLE },
 
 	/* GPIO_135 - Unused (TP128) */
 	{ GPIO_135, Function1, FCH_GPIO_PULL_UP_ENABLE },

-- 
To view, visit https://review.coreboot.org/23224
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I16792b76252506a43aac92738b04096ae3fde01c
Gerrit-Change-Number: 23224
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180111/8a8608ab/attachment.html>