<p>Martin Roth has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23224">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mainboard/google/kahlee: Fix GPIO table<br><br>The GPIOS that are being set low had the wrong value getting set.<br>FCH_GPIO_OUTPUT_VALUE was being set instead of FCH_GPIO_OUTPUT_ENABLE.<br><br>BUG=b:70234300<br>TEST=Build and boot Grunt<br><br>Change-Id: I16792b76252506a43aac92738b04096ae3fde01c<br>Signed-off-by: Martin Roth <martinroth@google.com><br>---<br>M src/mainboard/google/kahlee/variants/baseboard/gpio.c<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/23224/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/kahlee/variants/baseboard/gpio.c b/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>index 250fcc1..58d9473 100644</span><br><span>--- a/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>+++ b/src/mainboard/google/kahlee/variants/baseboard/gpio.c</span><br><span>@@ -112,7 +112,7 @@</span><br><span>        { GPIO_42, Function0, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE },</span><br><span> </span><br><span>  /* GPIO_67 - PEN_RESET */</span><br><span style="color: hsl(0, 100%, 40%);">-       { GPIO_67, Function0, FCH_GPIO_OUTPUT_VALUE },</span><br><span style="color: hsl(120, 100%, 40%);">+        { GPIO_67, Function0, FCH_GPIO_OUTPUT_ENABLE },</span><br><span> </span><br><span>  /* GPIO_70 - WLAN_PE_RST_L */</span><br><span>        { GPIO_70, Function0, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE },</span><br><span>@@ -127,10 +127,10 @@</span><br><span>      { GPIO_76, Function0, FCH_GPIO_OUTPUT_VALUE | FCH_GPIO_OUTPUT_ENABLE },</span><br><span> </span><br><span>  /* GPIO_84 - HUB_RST (Active High) */</span><br><span style="color: hsl(0, 100%, 40%);">-   { GPIO_84, Function1, FCH_GPIO_OUTPUT_VALUE },</span><br><span style="color: hsl(120, 100%, 40%);">+        { GPIO_84, Function1, FCH_GPIO_OUTPUT_ENABLE },</span><br><span> </span><br><span>  /* GPIO_85 - TOUCHSCREEN_RST (Active High) */</span><br><span style="color: hsl(0, 100%, 40%);">-   { GPIO_85, Function1, FCH_GPIO_OUTPUT_VALUE },</span><br><span style="color: hsl(120, 100%, 40%);">+        { GPIO_85, Function1, FCH_GPIO_OUTPUT_ENABLE },</span><br><span> </span><br><span>  /* GPIO_86 - Unused (TP109) */</span><br><span>       { GPIO_86, Function1, FCH_GPIO_PULL_UP_ENABLE },</span><br><span>@@ -208,7 +208,7 @@</span><br><span>       { GPIO_132, Function2,  },</span><br><span> </span><br><span>       /* GPIO_133 - APU_EDP_BKLTEN_L (backlight - Active LOW) */</span><br><span style="color: hsl(0, 100%, 40%);">-      { GPIO_133, Function1, FCH_GPIO_OUTPUT_VALUE },</span><br><span style="color: hsl(120, 100%, 40%);">+       { GPIO_133, Function1, FCH_GPIO_OUTPUT_ENABLE },</span><br><span> </span><br><span>         /* GPIO_135 - Unused (TP128) */</span><br><span>      { GPIO_135, Function1, FCH_GPIO_PULL_UP_ENABLE },</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23224">change 23224</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23224"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I16792b76252506a43aac92738b04096ae3fde01c </div>
<div style="display:none"> Gerrit-Change-Number: 23224 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Roth <martinroth@google.com> </div>