[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: select NO_UART_ON_SUPERIO

[Hannah Williams (Code Review)]

Hello Ravishankar Sarawadi,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/23219

to review the following change.


Change subject: soc/intel/apollolake: select NO_UART_ON_SUPERIO
......................................................................

soc/intel/apollolake: select NO_UART_ON_SUPERIO

If not, legacy COM ports will be enumerated by kernel and console will
not work
localhost ~ # cat /proc/tty/driver/serial
serinfo:1.0 driver revision:
0: uart:16550A port:000003F8 irq:4 tx:0 rx:0
1: uart:16550A mmio:0xC112D000 irq:4 tx:764 rx:0 RTS|DTR
2: uart:16550A mmio:0xC112F000 irq:6 tx:0 rx:0
3: uart:unknown port:000002E8 irq:3

With this fix:
0: uart:16550A mmio:0xC112D000 irq:4 tx:0 rx:0
1: uart:16550A mmio:0xC112F000 irq:6 tx:858 rx:42 RTS|DTR
2: uart:unknown port:000003E8 irq:4
3: uart:unknown port:000002E8 irq:3

Change-Id: Iac5bf65900e090d4e785e0cd828272ebff209458
Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi at intel.com>
---
M src/soc/intel/apollolake/Kconfig
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/23219/1

diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig
index 2d5363d..bd6f645 100644
--- a/src/soc/intel/apollolake/Kconfig
+++ b/src/soc/intel/apollolake/Kconfig
@@ -101,6 +101,7 @@
 	select HAVE_HARD_RESET
 	select INTEL_GMA_ADD_VBT_DATA_FILE if RUN_FSP_GOP
 	select HAVE_FSP_GOP
+	select NO_UART_ON_SUPERIO
 
 config CHROMEOS
 	select CHROMEOS_RAMOOPS_DYNAMIC

-- 
To view, visit https://review.coreboot.org/23219
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac5bf65900e090d4e785e0cd828272ebff209458
Gerrit-Change-Number: 23219
Gerrit-PatchSet: 1
Gerrit-Owner: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180111/71487764/attachment.html>