<p>Hannah Williams would like Ravishankar Sarawadi to <strong>review</strong> this change.</p><p><a href="https://review.coreboot.org/23219">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/intel/apollolake: select NO_UART_ON_SUPERIO<br><br>If not, legacy COM ports will be enumerated by kernel and console will<br>not work<br>localhost ~ # cat /proc/tty/driver/serial<br>serinfo:1.0 driver revision:<br>0: uart:16550A port:000003F8 irq:4 tx:0 rx:0<br>1: uart:16550A mmio:0xC112D000 irq:4 tx:764 rx:0 RTS|DTR<br>2: uart:16550A mmio:0xC112F000 irq:6 tx:0 rx:0<br>3: uart:unknown port:000002E8 irq:3<br><br>With this fix:<br>0: uart:16550A mmio:0xC112D000 irq:4 tx:0 rx:0<br>1: uart:16550A mmio:0xC112F000 irq:6 tx:858 rx:42 RTS|DTR<br>2: uart:unknown port:000003E8 irq:4<br>3: uart:unknown port:000002E8 irq:3<br><br>Change-Id: Iac5bf65900e090d4e785e0cd828272ebff209458<br>Signed-off-by: Ravi Sarawadi <ravishankar.sarawadi@intel.com><br>---<br>M src/soc/intel/apollolake/Kconfig<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/23219/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig</span><br><span>index 2d5363d..bd6f645 100644</span><br><span>--- a/src/soc/intel/apollolake/Kconfig</span><br><span>+++ b/src/soc/intel/apollolake/Kconfig</span><br><span>@@ -101,6 +101,7 @@</span><br><span>  select HAVE_HARD_RESET</span><br><span>       select INTEL_GMA_ADD_VBT_DATA_FILE if RUN_FSP_GOP</span><br><span>    select HAVE_FSP_GOP</span><br><span style="color: hsl(120, 100%, 40%);">+   select NO_UART_ON_SUPERIO</span><br><span> </span><br><span> config CHROMEOS</span><br><span>     select CHROMEOS_RAMOOPS_DYNAMIC</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23219">change 23219</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23219"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Iac5bf65900e090d4e785e0cd828272ebff209458 </div>
<div style="display:none"> Gerrit-Change-Number: 23219 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Hannah Williams <hannah.williams@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi@intel.com> </div>