[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy: [WIP] Split ports and endpoints config for CIO2

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has uploaded this change for review. ( https://review.coreboot.org/23167


Change subject: mb/google/poppy: [WIP] Split ports and endpoints config for CIO2
......................................................................

mb/google/poppy: [WIP] Split ports and endpoints config for CIO2

The variant boards can have a custom endpoints, splitting the ASL code
aids is customizing the endpoints as per the variant board setup.

BUG=None
BRANCH=None
TEST=build boot soraka, verify that the cameras are working fine and
generated DSDT tables are same as before.

Change-Id: I5f1cded25bfb6a7baf18b211f9773dfecdc2f264
Signed-off-by: Rizwan Qureshi <rizwan.qureshi at intel.com>
---
M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera.asl
A src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_endpoints.asl
M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_mainboard.asl
3 files changed, 49 insertions(+), 25 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/23167/1

diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera.asl
index 78f9108..1a6e63f 100644
--- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera.asl
+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera.asl
@@ -14,4 +14,5 @@
  */
 
 #include "ipu_mainboard.asl"
+#include "ipu_endpoints.asl"
 #include "mipi_camera.asl"
diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_endpoints.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_endpoints.asl
new file mode 100644
index 0000000..9d6de60
--- /dev/null
+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_endpoints.asl
@@ -0,0 +1,46 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2018 Intel Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+Scope (\_SB.PCI0.CIO2)
+{
+        /* Define two endpoints for CIO2 device where endpoint of port0
+	is connected to CAM0 and endpoint of port1 is connected to CAM1.
+	variant of this poppy baseboard can define their own endpoints (max 2)
+	with custom remote-endpoint */
+
+	Name (EP00, Package() {
+		ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+		Package () {
+			Package () { "endpoint", 0 },
+			Package () { "clock-lanes", 0 },
+			Package () { "data-lanes", Package () { 1, 2, 3, 4 } },
+			Package () { "remote-endpoint",
+				Package() { \_SB.PCI0.I2C2.CAM0, 0, 0 }
+			},
+		}
+	})
+
+	Name (EP10, Package() {
+		ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
+		Package () {
+			Package () { "endpoint", 0 },
+			Package () { "clock-lanes", 0 },
+			Package () { "data-lanes", Package () { 1, 2 } },
+			Package () { "remote-endpoint",
+				Package() { \_SB.PCI0.I2C4.CAM1, 0, 0 }
+			},
+		}
+	})
+}
diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_mainboard.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_mainboard.asl
index 3cf82ae..6f4a87b 100644
--- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_mainboard.asl
+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_mainboard.asl
@@ -16,7 +16,8 @@
 Scope (\_SB.PCI0.CIO2)
 {
         /* Define two ports for CIO2 device where endpoint of port0
-	is connected to CAM0 and endpoint of port1 is connected to CAM1 */
+	is connected to CAM0 and endpoint of port1 is connected to CAM1
+	Endpoints can be customized by the variants of the based board */
 
 	Name (_DSD, Package () {
 		ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),
@@ -37,18 +38,6 @@
 		}
 	})
 
-	Name (EP00, Package() {
-		ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
-		Package () {
-			Package () { "endpoint", 0 },
-			Package () { "clock-lanes", 0 },
-			Package () { "data-lanes", Package () { 1, 2, 3, 4 } },
-			Package () { "remote-endpoint",
-				Package() { \_SB.PCI0.I2C2.CAM0, 0, 0 }
-			},
-		}
-	})
-
 	Name (PRT1, Package () {
 		ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
 		Package () {
@@ -59,16 +48,4 @@
 			Package () { "endpoint0", "EP10" },
 		}
 	})
-
-	Name (EP10, Package() {
-		ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
-		Package () {
-			Package () { "endpoint", 0 },
-			Package () { "clock-lanes", 0 },
-			Package () { "data-lanes", Package () { 1, 2 } },
-			Package () { "remote-endpoint",
-				Package() { \_SB.PCI0.I2C4.CAM1, 0, 0 }
-			},
-		}
-	})
 }

-- 
To view, visit https://review.coreboot.org/23167
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f1cded25bfb6a7baf18b211f9773dfecdc2f264
Gerrit-Change-Number: 23167
Gerrit-PatchSet: 1
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180108/d5ab246d/attachment.html>