<p>Rizwan Qureshi has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23167">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy: [WIP] Split ports and endpoints config for CIO2<br><br>The variant boards can have a custom endpoints, splitting the ASL code<br>aids is customizing the endpoints as per the variant board setup.<br><br>BUG=None<br>BRANCH=None<br>TEST=build boot soraka, verify that the cameras are working fine and<br>generated DSDT tables are same as before.<br><br>Change-Id: I5f1cded25bfb6a7baf18b211f9773dfecdc2f264<br>Signed-off-by: Rizwan Qureshi <rizwan.qureshi@intel.com><br>---<br>M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera.asl<br>A src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_endpoints.asl<br>M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_mainboard.asl<br>3 files changed, 49 insertions(+), 25 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/23167/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera.asl</span><br><span>index 78f9108..1a6e63f 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera.asl</span><br><span>+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera.asl</span><br><span>@@ -14,4 +14,5 @@</span><br><span> */</span><br><span> </span><br><span> #include "ipu_mainboard.asl"</span><br><span style="color: hsl(120, 100%, 40%);">+#include "ipu_endpoints.asl"</span><br><span> #include "mipi_camera.asl"</span><br><span>diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_endpoints.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_endpoints.asl</span><br><span>new file mode 100644</span><br><span>index 0000000..9d6de60</span><br><span>--- /dev/null</span><br><span>+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_endpoints.asl</span><br><span>@@ -0,0 +1,46 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * This file is part of the coreboot project.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2018 Intel Corporation.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software; you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation; version 2 of the License.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+Scope (\_SB.PCI0.CIO2)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Define two endpoints for CIO2 device where endpoint of port0</span><br><span style="color: hsl(120, 100%, 40%);">+ is connected to CAM0 and endpoint of port1 is connected to CAM1.</span><br><span style="color: hsl(120, 100%, 40%);">+ variant of this poppy baseboard can define their own endpoints (max 2)</span><br><span style="color: hsl(120, 100%, 40%);">+ with custom remote-endpoint */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (EP00, Package() {</span><br><span style="color: hsl(120, 100%, 40%);">+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "endpoint", 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "clock-lanes", 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "data-lanes", Package () { 1, 2, 3, 4 } },</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "remote-endpoint",</span><br><span style="color: hsl(120, 100%, 40%);">+ Package() { \_SB.PCI0.I2C2.CAM0, 0, 0 }</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ })</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ Name (EP10, Package() {</span><br><span style="color: hsl(120, 100%, 40%);">+ ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () {</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "endpoint", 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "clock-lanes", 0 },</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "data-lanes", Package () { 1, 2 } },</span><br><span style="color: hsl(120, 100%, 40%);">+ Package () { "remote-endpoint",</span><br><span style="color: hsl(120, 100%, 40%);">+ Package() { \_SB.PCI0.I2C4.CAM1, 0, 0 }</span><br><span style="color: hsl(120, 100%, 40%);">+ },</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ })</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_mainboard.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_mainboard.asl</span><br><span>index 3cf82ae..6f4a87b 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_mainboard.asl</span><br><span>+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/ipu_mainboard.asl</span><br><span>@@ -16,7 +16,8 @@</span><br><span> Scope (\_SB.PCI0.CIO2)</span><br><span> {</span><br><span> /* Define two ports for CIO2 device where endpoint of port0</span><br><span style="color: hsl(0, 100%, 40%);">- is connected to CAM0 and endpoint of port1 is connected to CAM1 */</span><br><span style="color: hsl(120, 100%, 40%);">+ is connected to CAM0 and endpoint of port1 is connected to CAM1</span><br><span style="color: hsl(120, 100%, 40%);">+ Endpoints can be customized by the variants of the based board */</span><br><span> </span><br><span> Name (_DSD, Package () {</span><br><span> ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),</span><br><span>@@ -37,18 +38,6 @@</span><br><span> }</span><br><span> })</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- Name (EP00, Package() {</span><br><span style="color: hsl(0, 100%, 40%);">- ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span style="color: hsl(0, 100%, 40%);">- Package () {</span><br><span style="color: hsl(0, 100%, 40%);">- Package () { "endpoint", 0 },</span><br><span style="color: hsl(0, 100%, 40%);">- Package () { "clock-lanes", 0 },</span><br><span style="color: hsl(0, 100%, 40%);">- Package () { "data-lanes", Package () { 1, 2, 3, 4 } },</span><br><span style="color: hsl(0, 100%, 40%);">- Package () { "remote-endpoint",</span><br><span style="color: hsl(0, 100%, 40%);">- Package() { \_SB.PCI0.I2C2.CAM0, 0, 0 }</span><br><span style="color: hsl(0, 100%, 40%);">- },</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- })</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> Name (PRT1, Package () {</span><br><span> ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span> Package () {</span><br><span>@@ -59,16 +48,4 @@</span><br><span> Package () { "endpoint0", "EP10" },</span><br><span> }</span><br><span> })</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- Name (EP10, Package() {</span><br><span style="color: hsl(0, 100%, 40%);">- ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),</span><br><span style="color: hsl(0, 100%, 40%);">- Package () {</span><br><span style="color: hsl(0, 100%, 40%);">- Package () { "endpoint", 0 },</span><br><span style="color: hsl(0, 100%, 40%);">- Package () { "clock-lanes", 0 },</span><br><span style="color: hsl(0, 100%, 40%);">- Package () { "data-lanes", Package () { 1, 2 } },</span><br><span style="color: hsl(0, 100%, 40%);">- Package () { "remote-endpoint",</span><br><span style="color: hsl(0, 100%, 40%);">- Package() { \_SB.PCI0.I2C4.CAM1, 0, 0 }</span><br><span style="color: hsl(0, 100%, 40%);">- },</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">- })</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23167">change 23167</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23167"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I5f1cded25bfb6a7baf18b211f9773dfecdc2f264 </div>
<div style="display:none"> Gerrit-Change-Number: 23167 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi@intel.com> </div>