[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy: Add internal pull-up on pen eject signal

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/23143


Change subject: mb/google/poppy: Add internal pull-up on pen eject signal
......................................................................

mb/google/poppy: Add internal pull-up on pen eject signal

Since the current hardware revision does not have external pull on the
pen eject signal, this change adds internal pull-up on it.

Change-Id: I426d9833d7efbd8735b6f2b4896d1012b62cb4b8
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/poppy/variants/baseboard/gpio.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/23143/1

diff --git a/src/mainboard/google/poppy/variants/baseboard/gpio.c b/src/mainboard/google/poppy/variants/baseboard/gpio.c
index a6b9af0..8b9a21b 100644
--- a/src/mainboard/google/poppy/variants/baseboard/gpio.c
+++ b/src/mainboard/google/poppy/variants/baseboard/gpio.c
@@ -177,7 +177,7 @@
 	/* D7  : ISH_I2C1_SDA ==> NC */
 	PAD_CFG_NC(GPP_D7),
 	/* D8  : ISH_I2C1_SCL ==> PEN_EJECT_ODL -- for notification */
-	PAD_CFG_GPI(GPP_D8, NONE, PLTRST),
+	PAD_CFG_GPI(GPP_D8, 20K_PU, PLTRST),
 	/* D9  : ISH_SPI_CS# ==> HP_IRQ_GPIO */
 	PAD_CFG_GPI_GPIO_DRIVER(GPP_D9, NONE, PLTRST),
 	/* D10 : ISH_SPI_CLK ==> SPKR_RST_L */
@@ -185,7 +185,7 @@
 	/* D11 : ISH_SPI_MISO ==> SPKR_INT_L */
 	PAD_CFG_GPI_APIC(GPP_D11, NONE, PLTRST),
 	/* D12 : ISH_SPI_MOSI ==> PEN_EJECT_ODL -- for wake event */
-	PAD_CFG_GPI_ACPI_SCI(GPP_D12, NONE, DEEP, INVERT),
+	PAD_CFG_GPI_ACPI_SCI(GPP_D12, 20K_PU, DEEP, INVERT),
 	/* D13 : ISH_UART0_RXD ==> NC */
 	PAD_CFG_NC(GPP_D13),
 	/* D14 : ISH_UART0_TXD ==> NC */

-- 
To view, visit https://review.coreboot.org/23143
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I426d9833d7efbd8735b6f2b4896d1012b62cb4b8
Gerrit-Change-Number: 23143
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180106/c602bf02/attachment-0001.html>