<p>Furquan Shaikh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23143">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/poppy: Add internal pull-up on pen eject signal<br><br>Since the current hardware revision does not have external pull on the<br>pen eject signal, this change adds internal pull-up on it.<br><br>Change-Id: I426d9833d7efbd8735b6f2b4896d1012b62cb4b8<br>Signed-off-by: Furquan Shaikh <furquan@google.com><br>---<br>M src/mainboard/google/poppy/variants/baseboard/gpio.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/23143/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/baseboard/gpio.c b/src/mainboard/google/poppy/variants/baseboard/gpio.c</span><br><span>index a6b9af0..8b9a21b 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/baseboard/gpio.c</span><br><span>+++ b/src/mainboard/google/poppy/variants/baseboard/gpio.c</span><br><span>@@ -177,7 +177,7 @@</span><br><span>    /* D7  : ISH_I2C1_SDA ==> NC */</span><br><span>   PAD_CFG_NC(GPP_D7),</span><br><span>  /* D8  : ISH_I2C1_SCL ==> PEN_EJECT_ODL -- for notification */</span><br><span style="color: hsl(0, 100%, 40%);">-       PAD_CFG_GPI(GPP_D8, NONE, PLTRST),</span><br><span style="color: hsl(120, 100%, 40%);">+    PAD_CFG_GPI(GPP_D8, 20K_PU, PLTRST),</span><br><span>         /* D9  : ISH_SPI_CS# ==> HP_IRQ_GPIO */</span><br><span>   PAD_CFG_GPI_GPIO_DRIVER(GPP_D9, NONE, PLTRST),</span><br><span>       /* D10 : ISH_SPI_CLK ==> SPKR_RST_L */</span><br><span>@@ -185,7 +185,7 @@</span><br><span>      /* D11 : ISH_SPI_MISO ==> SPKR_INT_L */</span><br><span>   PAD_CFG_GPI_APIC(GPP_D11, NONE, PLTRST),</span><br><span>     /* D12 : ISH_SPI_MOSI ==> PEN_EJECT_ODL -- for wake event */</span><br><span style="color: hsl(0, 100%, 40%);">- PAD_CFG_GPI_ACPI_SCI(GPP_D12, NONE, DEEP, INVERT),</span><br><span style="color: hsl(120, 100%, 40%);">+    PAD_CFG_GPI_ACPI_SCI(GPP_D12, 20K_PU, DEEP, INVERT),</span><br><span>         /* D13 : ISH_UART0_RXD ==> NC */</span><br><span>  PAD_CFG_NC(GPP_D13),</span><br><span>         /* D14 : ISH_UART0_TXD ==> NC */</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23143">change 23143</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23143"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I426d9833d7efbd8735b6f2b4896d1012b62cb4b8 </div>
<div style="display:none"> Gerrit-Change-Number: 23143 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Furquan Shaikh <furquan@google.com> </div>