[coreboot-gerrit] Change in coreboot[master]: Nami: Enable elan touchpad

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/23133 )

Change subject: Nami: Enable elan touchpad
......................................................................


Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/23133/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/23133/1//COMMIT_MSG@9
PS1, Line 9: none
b:70124584


https://review.coreboot.org/#/c/23133/1//COMMIT_MSG@13
PS1, Line 13: 
You need a Signed-off-by line here.


https://review.coreboot.org/#/c/23133/1/src/mainboard/google/poppy/variants/nami/devicetree.cb
File src/mainboard/google/poppy/variants/nami/devicetree.cb:

https://review.coreboot.org/#/c/23133/1/src/mainboard/google/poppy/variants/nami/devicetree.cb@258
PS1, Line 258: 				register "wake" = "GPP_C7"
This doesn't look right. It should be GPE_.. Also, I don't think GPP_C7 is the right pin. It is marked as TRACKPAD_DISABLE in gpio.c



-- 
To view, visit https://review.coreboot.org/23133
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I14471d1473a3b3ecf15aaf362b47874704cd3bf0
Gerrit-Change-Number: 23133
Gerrit-PatchSet: 1
Gerrit-Owner: Van Chen <van_chen at compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Kaiyen Chang <kaiyen.chang at intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 05 Jan 2018 10:22:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180105/b7a78e42/attachment.html>