<p><a href="https://review.coreboot.org/23133">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23133/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23133/1//COMMIT_MSG@9">Patch Set #1, Line 9:</a> <code style="font-family:monospace,monospace">none</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">b:70124584</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23133/1//COMMIT_MSG@13">Patch Set #1, Line 13:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">You need a Signed-off-by line here.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23133/1/src/mainboard/google/poppy/variants/nami/devicetree.cb">File src/mainboard/google/poppy/variants/nami/devicetree.cb:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23133/1/src/mainboard/google/poppy/variants/nami/devicetree.cb@258">Patch Set #1, Line 258:</a> <code style="font-family:monospace,monospace">                         register "wake" = "GPP_C7"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This doesn't look right. It should be GPE_.. Also, I don't think GPP_C7 is the right pin. It is marked as TRACKPAD_DISABLE in gpio.c</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/23133">change 23133</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23133"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I14471d1473a3b3ecf15aaf362b47874704cd3bf0 </div>
<div style="display:none"> Gerrit-Change-Number: 23133 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Van Chen <van_chen@compal.corp-partner.google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Furquan Shaikh <furquan@google.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kaiyen Chang <kaiyen.chang@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kane Chen <kane.chen@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 05 Jan 2018 10:22:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>