[coreboot-gerrit] Change in coreboot[master]: util/gitconfig: Use `make` in git hooks

Patrick Georgi (Code Review) gerrit at coreboot.org
Thu Jan 4 21:24:18 CET 2018


Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/23096 )

Change subject: util/gitconfig: Use `make` in git hooks
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/23096/2/util/gitconfig/gitconfig.sh
File util/gitconfig/gitconfig.sh:

https://review.coreboot.org/#/c/23096/2/util/gitconfig/gitconfig.sh@a10
PS2, Line 10: 
or add MAKE?=make somewhere and use s,%MAKE%,${MAKE},g here? that way it uses make by default and whatever the build system was called with in case of "make gitconfig".



-- 
To view, visit https://review.coreboot.org/23096
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia78e06567b904b342dc9b7778569201fe02e6897
Gerrit-Change-Number: 23096
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot at gmail.com>
Gerrit-Reviewer: Alex Thiessen <alex.thiessen.de+coreboot at gmail.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 04 Jan 2018 20:24:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180104/19155e98/attachment.html>


More information about the coreboot-gerrit mailing list