[coreboot-gerrit] Change in coreboot[master]: util/gitconfig: Use `make` in git hooks
Alex Thiessen (Code Review)
gerrit at coreboot.org
Thu Jan 4 21:13:17 CET 2018
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/23096
to look at the new patch set (#2).
Change subject: util/gitconfig: Use `make` in git hooks
......................................................................
util/gitconfig: Use `make` in git hooks
As the code was moved from the Makefile.inc to a separate file in
commit 9ab8ae6a (util/gitconfig: Make gitconfig a bash script),`$(MAKE)`
was replaced by `remake`, introducing dependency on this tool which is
basically a `make` with debugging capabilities. Many developers don't
have `remake` installed, leading to pre-commit hooks being not executed
properly. Apparently this was an unintentional change.
Furthermore, special treatment of `make` tool via the `%MAKE%`
substitution performed during hooks' deployment doesn't seem justified.
It was introduced in commit f3947152 (gitconfig: Use the right make
executable in git hooks) and back then, `make` was called via `exec`.
This is not the case anymore since commit b18f522b (lint/gitconfig:
Enable checkpatch.pl checking of commits) and I think it's obsolete now.
Replace `sed` and `chmod +x` with `install` for brevity.
Change-Id: Ia78e06567b904b342dc9b7778569201fe02e6897
Signed-off-by: Alex Thiessen <alex.thiessen.de+coreboot at gmail.com>
---
M util/gitconfig/gitconfig.sh
M util/gitconfig/pre-commit
2 files changed, 3 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/23096/2
--
To view, visit https://review.coreboot.org/23096
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia78e06567b904b342dc9b7778569201fe02e6897
Gerrit-Change-Number: 23096
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Thiessen <alex.thiessen.de+coreboot at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180104/3bd68f84/attachment.html>
More information about the coreboot-gerrit
mailing list