[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Remove printk for GPIO

[Justin TerAvest (Code Review)]

Justin TerAvest has uploaded this change for review. ( https://review.coreboot.org/24915


Change subject: soc/amd/stoneyridge: Remove printk for GPIO
......................................................................

soc/amd/stoneyridge: Remove printk for GPIO

The printk() calls in sb_program_gpios() aren't necessary, and incur a
13 second delay if the function is called from
bootblock_mainboard_early_init(). This commit removes them so GPIOs can
be set up earlier.

TEST=call sb_program_gpios from bootblock_mainboard_early_init
BUG=None

Change-Id: I064291decf47d86132e36469e029b3262ec20172
Signed-off-by: Justin TerAvest <teravest at chromium.org>
---
M src/soc/amd/stoneyridge/southbridge.c
1 file changed, 0 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/24915/1

diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c
index 5d7b73d..3d0cc74 100644
--- a/src/soc/amd/stoneyridge/southbridge.c
+++ b/src/soc/amd/stoneyridge/southbridge.c
@@ -161,7 +161,6 @@
 	void *tmp_ptr;
 	uint8_t control, mux, index;
 
-	printk(BIOS_SPEW, "GPIO programming stage %s\n", STR_GPIO_STAGE);
 	for (index = 0; index < size; index++) {
 		mux = gpio_ptr[index].function;
 		control = gpio_ptr[index].control;
@@ -176,7 +175,6 @@
 					AMD_GPIO_CONTROL + 2);
 		write8(tmp_ptr, control);
 	}
-	printk(BIOS_SPEW, "End GPIO programming\n");
 }
 
 /**

-- 
To view, visit https://review.coreboot.org/24915
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I064291decf47d86132e36469e029b3262ec20172
Gerrit-Change-Number: 24915
Gerrit-PatchSet: 1
Gerrit-Owner: Justin TerAvest <teravest at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180228/0a261ac2/attachment.html>