<p>Justin TerAvest has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/24915">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">soc/amd/stoneyridge: Remove printk for GPIO<br><br>The printk() calls in sb_program_gpios() aren't necessary, and incur a<br>13 second delay if the function is called from<br>bootblock_mainboard_early_init(). This commit removes them so GPIOs can<br>be set up earlier.<br><br>TEST=call sb_program_gpios from bootblock_mainboard_early_init<br>BUG=None<br><br>Change-Id: I064291decf47d86132e36469e029b3262ec20172<br>Signed-off-by: Justin TerAvest <teravest@chromium.org><br>---<br>M src/soc/amd/stoneyridge/southbridge.c<br>1 file changed, 0 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/24915/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c</span><br><span>index 5d7b73d..3d0cc74 100644</span><br><span>--- a/src/soc/amd/stoneyridge/southbridge.c</span><br><span>+++ b/src/soc/amd/stoneyridge/southbridge.c</span><br><span>@@ -161,7 +161,6 @@</span><br><span>       void *tmp_ptr;</span><br><span>       uint8_t control, mux, index;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-        printk(BIOS_SPEW, "GPIO programming stage %s\n", STR_GPIO_STAGE);</span><br><span>  for (index = 0; index < size; index++) {</span><br><span>          mux = gpio_ptr[index].function;</span><br><span>              control = gpio_ptr[index].control;</span><br><span>@@ -176,7 +175,6 @@</span><br><span>                                     AMD_GPIO_CONTROL + 2);</span><br><span>               write8(tmp_ptr, control);</span><br><span>    }</span><br><span style="color: hsl(0, 100%, 40%);">-       printk(BIOS_SPEW, "End GPIO programming\n");</span><br><span> }</span><br><span> </span><br><span> /**</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/24915">change 24915</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/24915"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I064291decf47d86132e36469e029b3262ec20172 </div>
<div style="display:none"> Gerrit-Change-Number: 24915 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Justin TerAvest <teravest@chromium.org> </div>