[coreboot-gerrit] Change in coreboot[master]: soc/intel/denverton_ns: Fill dimm info for SMBIOS table 17

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/23851 )

Change subject: soc/intel/denverton_ns: Fill dimm info for SMBIOS table 17
......................................................................


Patch Set 1:

(4 comments)

https://review.coreboot.org/#/c/23851/1/src/soc/intel/denverton_ns/hob_mem.c
File src/soc/intel/denverton_ns/hob_mem.c:

https://review.coreboot.org/#/c/23851/1/src/soc/intel/denverton_ns/hob_mem.c@56
PS1, Line 56: #if IS_ENABLED(CONFIG_DISPLAY_HOBS)
please don't use that many preprocessor directives.
It would be much easier to understand if you'd split it into multiple files.


https://review.coreboot.org/#/c/23851/1/src/soc/intel/denverton_ns/hob_mem.c@58
PS1, Line 58: 		const FSP_SMBIOS_MEMORY_INFO *memory_info_hob)
align with opening bracket


https://review.coreboot.org/#/c/23851/1/src/soc/intel/denverton_ns/hob_mem.c@165
PS1, Line 165: 			if (dimm_info->SizeInMb) {
if (!dimm_info->SizeInMb)
continue;

to reduce indentation level


https://review.coreboot.org/#/c/23851/1/src/soc/intel/denverton_ns/hob_mem.c@223
PS1, Line 223: 	struct memory_info *mem_info,
align with opening bracket



-- 
To view, visit https://review.coreboot.org/23851
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5c4ceaf4e65359f72ec764f0914b5daa82f257e
Gerrit-Change-Number: 23851
Gerrit-PatchSet: 1
Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert at online.net>
Gerrit-Reviewer: Julien Viard de Galbert <jviarddegalbert at online.net>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Shine Liu <shine.liu at intel.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 24 Feb 2018 10:20:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180224/213f0fb6/attachment.html>