<p><a href="https://review.coreboot.org/23851">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23851/1/src/soc/intel/denverton_ns/hob_mem.c">File src/soc/intel/denverton_ns/hob_mem.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23851/1/src/soc/intel/denverton_ns/hob_mem.c@56">Patch Set #1, Line 56:</a> <code style="font-family:monospace,monospace">#if IS_ENABLED(CONFIG_DISPLAY_HOBS)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please don't use that many preprocessor directives.<br>It would be much easier to understand if you'd split it into multiple files.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23851/1/src/soc/intel/denverton_ns/hob_mem.c@58">Patch Set #1, Line 58:</a> <code style="font-family:monospace,monospace">                const FSP_SMBIOS_MEMORY_INFO *memory_info_hob)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">align with opening bracket</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23851/1/src/soc/intel/denverton_ns/hob_mem.c@165">Patch Set #1, Line 165:</a> <code style="font-family:monospace,monospace">                     if (dimm_info->SizeInMb) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">if (!dimm_info->SizeInMb)<br>continue;</p><p style="white-space: pre-wrap; word-wrap: break-word;">to reduce indentation level</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23851/1/src/soc/intel/denverton_ns/hob_mem.c@223">Patch Set #1, Line 223:</a> <code style="font-family:monospace,monospace">   struct memory_info *mem_info,</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">align with opening bracket</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/23851">change 23851</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23851"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Id5c4ceaf4e65359f72ec764f0914b5daa82f257e </div>
<div style="display:none"> Gerrit-Change-Number: 23851 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert@online.net> </div>
<div style="display:none"> Gerrit-Reviewer: Julien Viard de Galbert <jviarddegalbert@online.net> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: Shine Liu <shine.liu@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Sat, 24 Feb 2018 10:20:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>