[coreboot-gerrit] Change in coreboot[master]: fizz: Enable PCIe port 11, 12 on device tree

[Zhongze Hu (Code Review)]

Hello Zhongze Hu,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/23845

to review the following change.


Change subject: fizz: Enable PCIe port 11, 12 on device tree
......................................................................

fizz: Enable PCIe port 11, 12 on device tree

Our CFM daughter card would like to use individual PCIe lanes for two
different devices on the card.
dlaurie@ has reconfigured PCIe port 9-12 from 1x4 to 1x2 + 2x1 on b2b connector
on fizz to meet the requirement. We also need to enable the ports on device tree.

BUG=b:72523836
TEST=none
BRANCH=fizz
CQ-DEPEND=CL:*571936

Change-Id: Icded9850d833752680e0174b6c476e657817b319
Reviewed-on: https://chromium-review.googlesource.com/923867
Commit-Ready: Zhongze Hu <frankhu at google.com>
Tested-by: Zhongze Hu <frankhu at google.com>
Reviewed-by: Shelley Chen <shchen at chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/924860
Commit-Queue: Shelley Chen <shchen at chromium.org>
Tested-by: Shelley Chen <shchen at chromium.org>
---
M src/mainboard/google/fizz/devicetree.cb
1 file changed, 28 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/23845/1

diff --git a/src/mainboard/google/fizz/devicetree.cb b/src/mainboard/google/fizz/devicetree.cb
index 3b084ff..5eeb03c 100644
--- a/src/mainboard/google/fizz/devicetree.cb
+++ b/src/mainboard/google/fizz/devicetree.cb
@@ -228,6 +228,32 @@
 	# RP 9 uses uses CLK SRC 2
 	register "PcieRpClkSrcNumber[8]" = "2"
 
+	# Enable Root port 11 for BtoB.
+	register "PcieRpEnable[10]" = "1"
+	# Enable CLKREQ#
+	register "PcieRpClkReqSupport[10]" = "1"
+	# RP 11 uses SRCCLKREQ2#
+	register "PcieRpClkReqNumber[10]" = "2"
+	# RP 11, Enable Advanced Error Reporting
+	register "PcieRpAdvancedErrorReporting[10]" = "1"
+	# RP 11, Enable Latency Tolerance Reporting Mechanism
+	register "PcieRpLtrEnable[10]" = "1"
+	# RP 11 uses uses CLK SRC 2
+	register "PcieRpClkSrcNumber[10]" = "2"
+
+	# Enable Root port 12 for BtoB.
+	register "PcieRpEnable[11]" = "1"
+	# Enable CLKREQ#
+	register "PcieRpClkReqSupport[11]" = "1"
+	# RP 12 uses SRCCLKREQ2#
+	register "PcieRpClkReqNumber[11]" = "2"
+	# RP 12, Enable Advanced Error Reporting
+	register "PcieRpAdvancedErrorReporting[11]" = "1"
+	# RP 12, Enable Latency Tolerance Reporting Mechanism
+	register "PcieRpLtrEnable[11]" = "1"
+	# RP 12 uses uses CLK SRC 2
+	register "PcieRpClkSrcNumber[11]" = "2"
+
 	register "usb2_ports[0]" = "USB2_PORT_LONG(OC0)"	# Type-C
 	register "usb2_ports[1]" = "USB2_PORT_MID(OC3)"		# Type-A Rear
 	register "usb2_ports[2]" = "USB2_PORT_MID(OC2)"		# Type-A Front
@@ -351,8 +377,8 @@
 			end
 		end # PCI Express Port 9 for BtoB
 		device pci 1d.1 off end # PCI Express Port 10
-		device pci 1d.2 off end # PCI Express Port 11
-		device pci 1d.3 off end # PCI Express Port 12
+		device pci 1d.2 on end # PCI Express Port 11
+		device pci 1d.3 on end # PCI Express Port 12
 		device pci 1e.0 on  end # UART #0
 		device pci 1e.1 off end # UART #1
 		device pci 1e.2 on

-- 
To view, visit https://review.coreboot.org/23845
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icded9850d833752680e0174b6c476e657817b319
Gerrit-Change-Number: 23845
Gerrit-PatchSet: 1
Gerrit-Owner: Zhongze Hu <frankhu at chromium.org>
Gerrit-Reviewer: Zhongze Hu <frankhu at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180222/640ad36d/attachment.html>