[coreboot-gerrit] Change in coreboot[master]: mc_bdx1: Fix coverity error

[Werner Zeh (Code Review)]

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/23808


Change subject: mc_bdx1: Fix coverity error
......................................................................

mc_bdx1: Fix coverity error

Coverity scan has found an error (CID 1386126) where a NULL pointer is
dereferenced. The bug would happen if the devicetree does not contain a
valid entry for PCA9538. In this case the code
 * if (dev->path.i2c.device == PCA9538_SLAVE_ADR)
would dereference to a NULL pointer.

This patch fixes this issue. Thanks coverity!

Change-Id: I75e271d86c16fa3938420c43575ebba910f6a2fd
Signed-off-by: Werner Zeh <werner.zeh at siemens.com>
---
M src/mainboard/siemens/mc_bdx1/mainboard.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/23808/1

diff --git a/src/mainboard/siemens/mc_bdx1/mainboard.c b/src/mainboard/siemens/mc_bdx1/mainboard.c
index ebc6d40..da7da91 100644
--- a/src/mainboard/siemens/mc_bdx1/mainboard.c
+++ b/src/mainboard/siemens/mc_bdx1/mainboard.c
@@ -259,11 +259,11 @@
 struct device *pca9538_get_dev(void)
 {
 	struct device *dev = NULL;
-	do {
-		dev = dev_find_path(dev, DEVICE_PATH_I2C);
+
+	while ((dev = dev_find_path(dev, DEVICE_PATH_I2C))) {
 		if (dev->path.i2c.device == PCA9538_SLAVE_ADR)
 			break;
-	} while (dev);
+	};
 	return dev;
 }
 

-- 
To view, visit https://review.coreboot.org/23808
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75e271d86c16fa3938420c43575ebba910f6a2fd
Gerrit-Change-Number: 23808
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh <werner.zeh at siemens.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180219/f2a5d52c/attachment-0001.html>