<p>Werner Zeh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23808">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mc_bdx1: Fix coverity error<br><br>Coverity scan has found an error (CID 1386126) where a NULL pointer is<br>dereferenced. The bug would happen if the devicetree does not contain a<br>valid entry for PCA9538. In this case the code<br> * if (dev->path.i2c.device == PCA9538_SLAVE_ADR)<br>would dereference to a NULL pointer.<br><br>This patch fixes this issue. Thanks coverity!<br><br>Change-Id: I75e271d86c16fa3938420c43575ebba910f6a2fd<br>Signed-off-by: Werner Zeh <werner.zeh@siemens.com><br>---<br>M src/mainboard/siemens/mc_bdx1/mainboard.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/23808/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/siemens/mc_bdx1/mainboard.c b/src/mainboard/siemens/mc_bdx1/mainboard.c</span><br><span>index ebc6d40..da7da91 100644</span><br><span>--- a/src/mainboard/siemens/mc_bdx1/mainboard.c</span><br><span>+++ b/src/mainboard/siemens/mc_bdx1/mainboard.c</span><br><span>@@ -259,11 +259,11 @@</span><br><span> struct device *pca9538_get_dev(void)</span><br><span> {</span><br><span>    struct device *dev = NULL;</span><br><span style="color: hsl(0, 100%, 40%);">-      do {</span><br><span style="color: hsl(0, 100%, 40%);">-            dev = dev_find_path(dev, DEVICE_PATH_I2C);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  while ((dev = dev_find_path(dev, DEVICE_PATH_I2C))) {</span><br><span>                if (dev->path.i2c.device == PCA9538_SLAVE_ADR)</span><br><span>                    break;</span><br><span style="color: hsl(0, 100%, 40%);">-  } while (dev);</span><br><span style="color: hsl(120, 100%, 40%);">+        };</span><br><span>   return dev;</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23808">change 23808</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23808"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I75e271d86c16fa3938420c43575ebba910f6a2fd </div>
<div style="display:none"> Gerrit-Change-Number: 23808 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Werner Zeh <werner.zeh@siemens.com> </div>