[coreboot-gerrit] Change in coreboot[master]: mb/scaleway/tagada: Copy intel/harcuvar and rename

Julien Viard de Galbert (Code Review) gerrit at coreboot.org
Wed Feb 14 10:59:42 CET 2018


Julien Viard de Galbert has posted comments on this change. ( https://review.coreboot.org/23735 )

Change subject: mb/scaleway/tagada: Copy intel/harcuvar and rename
......................................................................


Patch Set 1:

I tried a mail reply hoping gerrit whould merge it in... it does not, lesson learned.
So here was the message:

Well, at least Paul Menzel told me, but in a slightly different context where the board ‘Cormorant Lake’ is a different reference board from Intel for the same SoC. See:
https://review.coreboot.org/c/coreboot/+/22308#message-2d3a4715_05bb85f3

Our board is based on the reference design of the ‘Cormorant Lake’ board, so I thought it made sense to base it on ‘Harcuvar’ too.
If most reviewer prefer a single commit here, I can squash those commits into only one.


-- 
To view, visit https://review.coreboot.org/23735
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fc1f8393ce3f5ba6f52edad7cf8efa5524d2704
Gerrit-Change-Number: 23735
Gerrit-PatchSet: 1
Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert at online.net>
Gerrit-Reviewer: Julien Viard de Galbert <jviarddegalbert at online.net>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 14 Feb 2018 09:59:42 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180214/dabc3f87/attachment.html>


More information about the coreboot-gerrit mailing list