[coreboot-gerrit] Change in coreboot[master]: mb/scaleway/tagada: Copy intel/harcuvar and rename

Nico Huber (Code Review) gerrit at coreboot.org
Wed Feb 14 00:20:25 CET 2018


Nico Huber has posted comments on this change. ( https://review.coreboot.org/23735 )

Change subject: mb/scaleway/tagada: Copy intel/harcuvar and rename
......................................................................


Patch Set 1:

Um, I hope nobody told you do add your board this way (copying another
and base changes on that). It's a sure way to keep flaws in the code;
because nobody is going to review this commit but only your later
changes. That's just my opinion, though. Other reviewers might see it
differently.


-- 
To view, visit https://review.coreboot.org/23735
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fc1f8393ce3f5ba6f52edad7cf8efa5524d2704
Gerrit-Change-Number: 23735
Gerrit-PatchSet: 1
Gerrit-Owner: Julien Viard de Galbert <jviarddegalbert at online.net>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 13 Feb 2018 23:20:25 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180213/155362b9/attachment.html>


More information about the coreboot-gerrit mailing list