[coreboot-gerrit] Change in coreboot[master]: security/tpm: Add SW hash functions for measurements

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/23711 )

Change subject: security/tpm: Add SW hash functions for measurements
......................................................................


Patch Set 4:

(3 comments)

https://review.coreboot.org/#/c/23711/4/src/security/crypto/Makefile.inc
File src/security/crypto/Makefile.inc:

https://review.coreboot.org/#/c/23711/4/src/security/crypto/Makefile.inc@a21
PS4, Line 21: 
why do you remove smm hash support ?


https://review.coreboot.org/#/c/23711/4/src/security/tpm/Kconfig
File src/security/tpm/Kconfig:

https://review.coreboot.org/#/c/23711/4/src/security/tpm/Kconfig@93
PS4, Line 93: 	  Enables hardware accerlated hashes. A TPM HW feature.
accelerated hashing


https://review.coreboot.org/#/c/23711/4/src/security/tpm/tspi/tspi.c
File src/security/tpm/tspi/tspi.c:

https://review.coreboot.org/#/c/23711/4/src/security/tpm/tspi/tspi.c@196
PS4, Line 196: #if IS_ENABLED(CONFIG_TPM_HW_HASHES)
please use if(IS_ENABLED(CONFIG_TPM_HW_HASHES))



-- 
To view, visit https://review.coreboot.org/23711
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice8a0de0294fe619ff725dc5126319fc2bc657ad
Gerrit-Change-Number: 23711
Gerrit-PatchSet: 4
Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 12 Feb 2018 17:27:48 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180212/e6e7de82/attachment.html>