<p><a href="https://review.coreboot.org/23711">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23711/4/src/security/crypto/Makefile.inc">File src/security/crypto/Makefile.inc:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23711/4/src/security/crypto/Makefile.inc@a21">Patch Set #4, Line 21:</a> <code style="font-family:monospace,monospace"></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">why do you remove smm hash support ?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23711/4/src/security/tpm/Kconfig">File src/security/tpm/Kconfig:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23711/4/src/security/tpm/Kconfig@93">Patch Set #4, Line 93:</a> <code style="font-family:monospace,monospace">        Enables hardware accerlated hashes. A TPM HW feature.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">accelerated hashing</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23711/4/src/security/tpm/tspi/tspi.c">File src/security/tpm/tspi/tspi.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23711/4/src/security/tpm/tspi/tspi.c@196">Patch Set #4, Line 196:</a> <code style="font-family:monospace,monospace">#if IS_ENABLED(CONFIG_TPM_HW_HASHES)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">please use if(IS_ENABLED(CONFIG_TPM_HW_HASHES))</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/23711">change 23711</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23711"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ice8a0de0294fe619ff725dc5126319fc2bc657ad </div>
<div style="display:none"> Gerrit-Change-Number: 23711 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Philipp Deppenwiese <zaolin.daisuki@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 12 Feb 2018 17:27:48 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>