[coreboot-gerrit] Change in coreboot[master]: [TEST] Fix CAR for P4 CPU's
Arthur Heymans (Code Review)
gerrit at coreboot.org
Sat Feb 10 16:17:12 CET 2018
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/23690
Change subject: [TEST] Fix CAR for P4 CPU's
......................................................................
[TEST] Fix CAR for P4 CPU's
when reading cpuid(4) it looks like the wrong ecx argument is
provided (4 instead of 0), despite what to code does. This leads to a
division by 0 later which has the code do wrong stuff.
Change-Id: I00cf86259d5c5c6e46e41a516cf585bbc11a26a2
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/cpu/intel/car/cache_as_ram_ht.inc
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/23690/1
diff --git a/src/cpu/intel/car/cache_as_ram_ht.inc b/src/cpu/intel/car/cache_as_ram_ht.inc
index e716caf..64e6083 100644
--- a/src/cpu/intel/car/cache_as_ram_ht.inc
+++ b/src/cpu/intel/car/cache_as_ram_ht.inc
@@ -136,6 +136,7 @@
movb $1, %bl
cmpl $4, %eax
jb cores_counted
+ movl $0, %ecx
movl $4, %eax
movl $0, %ecx
cpuid
--
To view, visit https://review.coreboot.org/23690
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I00cf86259d5c5c6e46e41a516cf585bbc11a26a2
Gerrit-Change-Number: 23690
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180210/4328c9db/attachment-0001.html>
More information about the coreboot-gerrit
mailing list