<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23690">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[TEST] Fix CAR for P4 CPU's<br><br>when reading cpuid(4) it looks like the wrong ecx argument is<br>provided (4 instead of 0), despite what to code does. This leads to a<br>division by 0 later which has the code do wrong stuff.<br><br>Change-Id: I00cf86259d5c5c6e46e41a516cf585bbc11a26a2<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/cpu/intel/car/cache_as_ram_ht.inc<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/23690/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/cpu/intel/car/cache_as_ram_ht.inc b/src/cpu/intel/car/cache_as_ram_ht.inc</span><br><span>index e716caf..64e6083 100644</span><br><span>--- a/src/cpu/intel/car/cache_as_ram_ht.inc</span><br><span>+++ b/src/cpu/intel/car/cache_as_ram_ht.inc</span><br><span>@@ -136,6 +136,7 @@</span><br><span>       movb    $1, %bl</span><br><span>      cmpl    $4, %eax</span><br><span>     jb      cores_counted</span><br><span style="color: hsl(120, 100%, 40%);">+ movl    $0, %ecx</span><br><span>     movl    $4, %eax</span><br><span>     movl    $0, %ecx</span><br><span>     cpuid</span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23690">change 23690</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23690"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: I00cf86259d5c5c6e46e41a516cf585bbc11a26a2 </div>
<div style="display:none"> Gerrit-Change-Number: 23690 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>