[coreboot-gerrit] Change in coreboot[master]: mb/kontron/986lcd-m: Disable ethernet devices in ramstage

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23663 )

Change subject: mb/kontron/986lcd-m: Disable ethernet devices in ramstage
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/23663/1/src/mainboard/kontron/986lcd-m/mainboard.c
File src/mainboard/kontron/986lcd-m/mainboard.c:

https://review.coreboot.org/#/c/23663/1/src/mainboard/kontron/986lcd-m/mainboard.c@175
PS1, Line 175: static void mainboard_enable(device_t dev)
Isn't that far too late (when hiding/coalescing is handled in chip->init)?



-- 
To view, visit https://review.coreboot.org/23663
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8abc4c8289f5e34bbb7d5ee57d9a2f404e26189
Gerrit-Change-Number: 23663
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 08 Feb 2018 22:54:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180208/2ac2ba10/attachment.html>