<p><a href="https://review.coreboot.org/23663">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23663/1/src/mainboard/kontron/986lcd-m/mainboard.c">File src/mainboard/kontron/986lcd-m/mainboard.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23663/1/src/mainboard/kontron/986lcd-m/mainboard.c@175">Patch Set #1, Line 175:</a> <code style="font-family:monospace,monospace">static void mainboard_enable(device_t dev)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Isn't that far too late (when hiding/coalescing is handled in chip->init)?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/23663">change 23663</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23663"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ic8abc4c8289f5e34bbb7d5ee57d9a2f404e26189 </div>
<div style="display:none"> Gerrit-Change-Number: 23663 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 08 Feb 2018 22:54:51 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>