[coreboot-gerrit] Change in coreboot[master]: sb/intel/i82801gx: Automatically handle disabling functions

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23662 )

Change subject: sb/intel/i82801gx: Automatically handle disabling functions
......................................................................


Patch Set 4:

(7 comments)

https://review.coreboot.org/#/c/23662/4/src/mainboard/kontron/986lcd-m/devicetree.cb
File src/mainboard/kontron/986lcd-m/devicetree.cb:

https://review.coreboot.org/#/c/23662/4/src/mainboard/kontron/986lcd-m/devicetree.cb@43
PS4, Line 43: 			register "pcie_port_coalesce" = "1"
Why? it would be enabled automatically if needed.


https://review.coreboot.org/#/c/23662/4/src/mainboard/kontron/986lcd-m/romstage.c
File src/mainboard/kontron/986lcd-m/romstage.c:

https://review.coreboot.org/#/c/23662/4/src/mainboard/kontron/986lcd-m/romstage.c@221
PS4, Line 221: 	reg32 |= 1;
Drop?


https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i82801gx.c
File src/southbridge/intel/i82801gx/i82801gx.c:

https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i82801gx.c@43
PS4, Line 43: BIOS_EMERG
It's not that bad, is it?


https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i82801gx.c@105
PS4, Line 105: 		chip_info->pcie_port_coalesce = 1;
Why? who else reads it?


https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i82801gx.c@113
PS4, Line 113: 		reg32 |= next_port++ << (i * 4);
Shouldn't `reg32` be written to some reg or something?


https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i82801gx.c@118
PS4, Line 118: 			reg32 |= next_port++ << (i * 4);
Ditto.


https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i82801gx.c@120
PS4, Line 120: }
Looks pretty simple, don't we have to patch the devicetree like bd82x6x does?



-- 
To view, visit https://review.coreboot.org/23662
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f6f270c631b97ececf1bd3c23f19b27828e6885
Gerrit-Change-Number: 23662
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 08 Feb 2018 21:51:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180208/b0b532e5/attachment.html>