<p><a href="https://review.coreboot.org/23662">View Change</a></p><p>7 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23662/4/src/mainboard/kontron/986lcd-m/devicetree.cb">File src/mainboard/kontron/986lcd-m/devicetree.cb:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23662/4/src/mainboard/kontron/986lcd-m/devicetree.cb@43">Patch Set #4, Line 43:</a> <code style="font-family:monospace,monospace">                     register "pcie_port_coalesce" = "1"</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why? it would be enabled automatically if needed.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23662/4/src/mainboard/kontron/986lcd-m/romstage.c">File src/mainboard/kontron/986lcd-m/romstage.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23662/4/src/mainboard/kontron/986lcd-m/romstage.c@221">Patch Set #4, Line 221:</a> <code style="font-family:monospace,monospace">     reg32 |= 1;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Drop?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i82801gx.c">File src/southbridge/intel/i82801gx/i82801gx.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i82801gx.c@43">Patch Set #4, Line 43:</a> <code style="font-family:monospace,monospace">BIOS_EMERG</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">It's not that bad, is it?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i82801gx.c@105">Patch Set #4, Line 105:</a> <code style="font-family:monospace,monospace">                chip_info->pcie_port_coalesce = 1;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why? who else reads it?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i82801gx.c@113">Patch Set #4, Line 113:</a> <code style="font-family:monospace,monospace">            reg32 |= next_port++ << (i * 4);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Shouldn't `reg32` be written to some reg or something?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i82801gx.c@118">Patch Set #4, Line 118:</a> <code style="font-family:monospace,monospace">                        reg32 |= next_port++ << (i * 4);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ditto.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i82801gx.c@120">Patch Set #4, Line 120:</a> <code style="font-family:monospace,monospace">}</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Looks pretty simple, don't we have to patch the devicetree like bd82x6x does?</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/23662">change 23662</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23662"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I2f6f270c631b97ececf1bd3c23f19b27828e6885 </div>
<div style="display:none"> Gerrit-Change-Number: 23662 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 08 Feb 2018 21:51:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>