[coreboot-gerrit] Change in coreboot[master]: mb/google/nautilus: To work around the power issue of MIPI and USB ca...

[Andy Yeh (Code Review)]

Andy Yeh has uploaded this change for review. ( https://review.coreboot.org/23546


Change subject: mb/google/nautilus: To work around the power issue of MIPI and USB cameras
......................................................................

mb/google/nautilus: To work around the power issue of MIPI and USB cameras

On EVT, the USB and MIPI cameras share the same power source; as a result,
when the MIPI camera driver turns of the camera, USB camera is turned off
as well. For USB cameras to work on EVT devices we will need a hack in
coreboot to leave the camera power always-on. This power issue will be fixed
on DVT build. Will revert this patch once confirmed power source could be
supplied standalone.

BUG=b:72616688
TEST: Verified the MIPI and USB camera function on DUT board

Change-Id: Icaaf7e17447492f2e2f2d03eb9a35bcc53667f28
Signed-off-by: Andy Yeh <andy.yeh at intel.com>
---
M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
1 file changed, 6 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/23546/1

diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
index 5eaf5b7..2b97043 100644
--- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl
@@ -39,7 +39,13 @@
 		Method (PMOF, 0, Serialized) {
 			/* Make Sure all PMIC outputs are off. */
 			If (LEqual (VSIC, Zero)) {
+			/*
+			 * On Nautilus Pre-EVT/EVT, the USB and MIPI share the same power source,
+			 * before HW fix in DVT, temporarily disabled turn off 3V3_VDD
+			 */
+#if !IS_ENABLED(CONFIG_BOARD_GOOGLE_NAUTILUS)
 				CTXS(EN_PP3300_DX_CAM)
+#endif
 			}
 		}
 

-- 
To view, visit https://review.coreboot.org/23546
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icaaf7e17447492f2e2f2d03eb9a35bcc53667f28
Gerrit-Change-Number: 23546
Gerrit-PatchSet: 1
Gerrit-Owner: Andy Yeh <andy.yeh at intel.corp-partner.google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180201/2e8336bd/attachment.html>