<p>Andy Yeh has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/23546">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/google/nautilus: To work around the power issue of MIPI and USB cameras<br><br>On EVT, the USB and MIPI cameras share the same power source; as a result,<br>when the MIPI camera driver turns of the camera, USB camera is turned off<br>as well. For USB cameras to work on EVT devices we will need a hack in<br>coreboot to leave the camera power always-on. This power issue will be fixed<br>on DVT build. Will revert this patch once confirmed power source could be<br>supplied standalone.<br><br>BUG=b:72616688<br>TEST: Verified the MIPI and USB camera function on DUT board<br><br>Change-Id: Icaaf7e17447492f2e2f2d03eb9a35bcc53667f28<br>Signed-off-by: Andy Yeh <andy.yeh@intel.com><br>---<br>M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl<br>1 file changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/23546/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl</span><br><span>index 5eaf5b7..2b97043 100644</span><br><span>--- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl</span><br><span>+++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl</span><br><span>@@ -39,7 +39,13 @@</span><br><span>              Method (PMOF, 0, Serialized) {</span><br><span>                       /* Make Sure all PMIC outputs are off. */</span><br><span>                    If (LEqual (VSIC, Zero)) {</span><br><span style="color: hsl(120, 100%, 40%);">+                    /*</span><br><span style="color: hsl(120, 100%, 40%);">+                     * On Nautilus Pre-EVT/EVT, the USB and MIPI share the same power source,</span><br><span style="color: hsl(120, 100%, 40%);">+                      * before HW fix in DVT, temporarily disabled turn off 3V3_VDD</span><br><span style="color: hsl(120, 100%, 40%);">+                         */</span><br><span style="color: hsl(120, 100%, 40%);">+#if !IS_ENABLED(CONFIG_BOARD_GOOGLE_NAUTILUS)</span><br><span>                           CTXS(EN_PP3300_DX_CAM)</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span>                       }</span><br><span>            }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/23546">change 23546</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/23546"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>
<div style="display:none"> Gerrit-Change-Id: Icaaf7e17447492f2e2f2d03eb9a35bcc53667f28 </div>
<div style="display:none"> Gerrit-Change-Number: 23546 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Andy Yeh <andy.yeh@intel.corp-partner.google.com> </div>