[coreboot-gerrit] Change in ...coreboot[master]: [WIP] mb/lenovo/dock.asl: Add proper dock support

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30397 )

Change subject: [WIP] mb/lenovo/dock.asl: Add proper dock support
......................................................................


Patch Set 1:

(3 comments)

Looks good, but could need more comments, to make it easier to compare with c code

https://review.coreboot.org/#/c/30397/1/src/mainboard/lenovo/t400/acpi/dock.asl 
File src/mainboard/lenovo/t400/acpi/dock.asl:

https://review.coreboot.org/#/c/30397/1/src/mainboard/lenovo/t400/acpi/dock.asl@140 
PS1, Line 140: 		OperationRegion (NSIO, SystemIO, DLPC_GPIO_BASE, 0x0C)
why is the pc87382 on the DOCK device, it's located on the mainboard ?


https://review.coreboot.org/#/c/30397/1/src/mainboard/lenovo/t400/acpi/dock.asl@167 
PS1, Line 167: 		Name (G_ID, 0xffffffff)
Ones


https://review.coreboot.org/#/c/30397/1/src/mainboard/lenovo/t400/acpi/dock.asl@191 
PS1, Line 191: 				If ((\_SB.DOCK.GGID () == 0x01))
DOCK_TYPE_2504



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30397
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifa4a5a0272c6d3ec0b65871e5c1448d395bc74a8
Gerrit-Change-Number: 30397
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Alexander Couzens <lynxis at fe80.eu>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 24 Dec 2018 10:06:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181224/94bba9a7/attachment.html>