<p style="white-space: pre-wrap; word-wrap: break-word;">Looks good, but could need more comments, to make it easier to compare with c code</p><p><a href="https://review.coreboot.org/c/coreboot/+/30397">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://review.coreboot.org/#/c/30397/1/src/mainboard/lenovo/t400/acpi/dock.asl">File src/mainboard/lenovo/t400/acpi/dock.asl:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30397/1/src/mainboard/lenovo/t400/acpi/dock.asl@140">Patch Set #1, Line 140:</a> <code style="font-family:monospace,monospace">                OperationRegion (NSIO, SystemIO, DLPC_GPIO_BASE, 0x0C)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">why is the pc87382 on the DOCK device, it's located on the mainboard ?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30397/1/src/mainboard/lenovo/t400/acpi/dock.asl@167">Patch Set #1, Line 167:</a> <code style="font-family:monospace,monospace">          Name (G_ID, 0xffffffff)</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ones</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://review.coreboot.org/#/c/30397/1/src/mainboard/lenovo/t400/acpi/dock.asl@191">Patch Set #1, Line 191:</a> <code style="font-family:monospace,monospace">                               If ((\_SB.DOCK.GGID () == 0x01))</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DOCK_TYPE_2504</p></li></ul></li></ul><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30397">change 30397</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30397"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifa4a5a0272c6d3ec0b65871e5c1448d395bc74a8 </div>
<div style="display:none"> Gerrit-Change-Number: 30397 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> </div>
<div style="display:none"> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 24 Dec 2018 10:06:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>