[coreboot-gerrit] Change in ...coreboot[master]: nb/intel/haswell: Add support for PCIe graphics

[Tristan Corrick (Code Review)]

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30272 )

Change subject: nb/intel/haswell: Add support for PCIe graphics
......................................................................


Patch Set 7:

(1 comment)

I've repeated the tests on the latest patch set.

https://review.coreboot.org/#/c/30272/6//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/30272/6//COMMIT_MSG@11 
PS6, Line 11: class present in a PEG slot, disable the IGD:
            : 
            : 	Before the MRC: GGC = 0x0208, DEVEN = 0x00000039.
            : 	After the MRC:  GGC = 0x0003, DEVEN = 0x00000029.
            : 
            : If the IGD needs to be kept enabled, the PEG device is hidden while the
            : MRC runs. The link training is able to continue even while the PEG
            : device is hidden.
            : 
            : Only PEG2 is supported. An extra (unknown) training sequence is said to
            : be needed for PEG3.
            : 
            : The ACPI _PRT method is not yet generated, so legacy interrupt routing
            : doesn't work for devices with multiple functions.
            : 
            : Tested on an ASRock H81M-HDS. Using an x1 PCIe card in the PEG slot
            : works fine. Using a Rade
> Would the following work? […]
Thank you for this idea! It looks like the link training continues even
when the PEG device is disabled. I've updated the patch to use this
approach, so there is now only a single boot flow.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30272
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I786ecb6eccad8de89778af7e736ed664323e220e
Gerrit-Change-Number: 30272
Gerrit-PatchSet: 7
Gerrit-Owner: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Tristan Corrick <tristan at corrick.kiwi>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Comment-Date: Mon, 24 Dec 2018 05:53:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181224/779737f4/attachment.html>