[coreboot-gerrit] Change in ...coreboot[master]: mb/lenovo/x200: Remove RCBA replay

Arthur Heymans (Code Review) gerrit at coreboot.org
Sun Dec 23 19:20:28 CET 2018


Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30402


Change subject: mb/lenovo/x200: Remove RCBA replay
......................................................................

mb/lenovo/x200: Remove RCBA replay

This either sets unwanted or unnecessary settings.

Change-Id: I0f552dea1b37cdc17c9dd26a0294b59063cdc2be
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/mainboard/lenovo/x200/romstage.c
1 file changed, 0 insertions(+), 33 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/30402/1

diff --git a/src/mainboard/lenovo/x200/romstage.c b/src/mainboard/lenovo/x200/romstage.c
index 8176fad..2cd1b21 100644
--- a/src/mainboard/lenovo/x200/romstage.c
+++ b/src/mainboard/lenovo/x200/romstage.c
@@ -119,39 +119,6 @@
 	i82801ix_dmi_poll_vc1();
 
 	MCHBAR16(SSKPD_MCHBAR) = 0xCAFE;
-	/* Enable ethernet.  */
-	RCBA32(0x3414) &= ~0x20;
-
-	RCBA32(0x0238) = 0x00543210;
-	RCBA32(0x0240) = 0x009c0b02;
-	RCBA32(0x0244) = 0x00a20b1a;
-	RCBA32(0x0248) = 0x005402cb;
-	RCBA32(0x0254) = 0x00470966;
-	RCBA32(0x0258) = 0x00470473;
-	RCBA32(0x0260) = 0x00e90825;
-	RCBA32(0x0278) = 0x00bc0efb;
-	RCBA32(0x027c) = 0x00c00f0b;
-	RCBA32(0x0280) = 0x00670000;
-	RCBA32(0x0284) = 0x006d0000;
-	RCBA32(0x0288) = 0x00600b4e;
-	RCBA32(0x1e10) = 0x00020800;
-	RCBA32(0x1e18) = 0x36ea00a0;
-	RCBA32(0x1e80) = 0x000c0801;
-	RCBA32(0x1e84) = 0x000200f0;
-	RCBA32(0x2028) = 0x04c8f95e;
-	RCBA32(0x202c) = 0x055c095e;
-	RCBA32(0x204c) = 0x001ffc00;
-	RCBA32(0x2050) = 0x00100fff;
-	RCBA32(0x2090) = 0x37000000;
-	RCBA32(0x20b0) = 0x0c000000;
-	RCBA32(0x20d0) = 0x09000000;
-	RCBA32(0x20f0) = 0x05000000;
-	RCBA32(0x3400) = 0x0000001c;
-	RCBA32(0x3410) = 0x00100461;
-	RCBA32(0x3414) = 0x00000000;
-	RCBA32(0x341c) = 0xbf4f001f;
-	RCBA32(0x3420) = 0x00000000;
-	RCBA32(0x3430) = 0x00000001;
 
 	init_iommu();
 

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30402
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0f552dea1b37cdc17c9dd26a0294b59063cdc2be
Gerrit-Change-Number: 30402
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181223/49082926/attachment.html>


More information about the coreboot-gerrit mailing list