<p>Arthur Heymans has uploaded this change for <strong>review</strong>.</p><p><a href="https://review.coreboot.org/c/coreboot/+/30402">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mb/lenovo/x200: Remove RCBA replay<br><br>This either sets unwanted or unnecessary settings.<br><br>Change-Id: I0f552dea1b37cdc17c9dd26a0294b59063cdc2be<br>Signed-off-by: Arthur Heymans <arthur@aheymans.xyz><br>---<br>M src/mainboard/lenovo/x200/romstage.c<br>1 file changed, 0 insertions(+), 33 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/30402/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mainboard/lenovo/x200/romstage.c b/src/mainboard/lenovo/x200/romstage.c</span><br><span>index 8176fad..2cd1b21 100644</span><br><span>--- a/src/mainboard/lenovo/x200/romstage.c</span><br><span>+++ b/src/mainboard/lenovo/x200/romstage.c</span><br><span>@@ -119,39 +119,6 @@</span><br><span>   i82801ix_dmi_poll_vc1();</span><br><span> </span><br><span>         MCHBAR16(SSKPD_MCHBAR) = 0xCAFE;</span><br><span style="color: hsl(0, 100%, 40%);">-        /* Enable ethernet.  */</span><br><span style="color: hsl(0, 100%, 40%);">- RCBA32(0x3414) &= ~0x20;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x0238) = 0x00543210;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x0240) = 0x009c0b02;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x0244) = 0x00a20b1a;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x0248) = 0x005402cb;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x0254) = 0x00470966;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x0258) = 0x00470473;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x0260) = 0x00e90825;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x0278) = 0x00bc0efb;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x027c) = 0x00c00f0b;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x0280) = 0x00670000;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x0284) = 0x006d0000;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x0288) = 0x00600b4e;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x1e10) = 0x00020800;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x1e18) = 0x36ea00a0;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x1e80) = 0x000c0801;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x1e84) = 0x000200f0;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x2028) = 0x04c8f95e;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x202c) = 0x055c095e;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x204c) = 0x001ffc00;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x2050) = 0x00100fff;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x2090) = 0x37000000;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x20b0) = 0x0c000000;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x20d0) = 0x09000000;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x20f0) = 0x05000000;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x3400) = 0x0000001c;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x3410) = 0x00100461;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x3414) = 0x00000000;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x341c) = 0xbf4f001f;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x3420) = 0x00000000;</span><br><span style="color: hsl(0, 100%, 40%);">-    RCBA32(0x3430) = 0x00000001;</span><br><span> </span><br><span>     init_iommu();</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://review.coreboot.org/c/coreboot/+/30402">change 30402</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://review.coreboot.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://review.coreboot.org/c/coreboot/+/30402"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: coreboot </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0f552dea1b37cdc17c9dd26a0294b59063cdc2be </div>
<div style="display:none"> Gerrit-Change-Number: 30402 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>