[coreboot-gerrit] Change in ...coreboot[master]: x86/smm/smmhandler.S: Use tabs instead of white spaces

HAOUAS Elyes (Code Review) gerrit at coreboot.org
Sat Dec 22 09:27:26 CET 2018


HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30377


Change subject: x86/smm/smmhandler.S: Use tabs instead of white spaces
......................................................................

x86/smm/smmhandler.S: Use tabs instead of white spaces

Change-Id: I7a10ddf79cf457b5dde21714b13890fc9510e7ce
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
M src/cpu/x86/smm/smmhandler.S
1 file changed, 26 insertions(+), 26 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/30377/1

diff --git a/src/cpu/x86/smm/smmhandler.S b/src/cpu/x86/smm/smmhandler.S
index 0989e89..3145ef0 100644
--- a/src/cpu/x86/smm/smmhandler.S
+++ b/src/cpu/x86/smm/smmhandler.S
@@ -107,13 +107,13 @@
 	ud2
 untampered_lapic:
 #endif
-	movw    $(smm_gdtptr16 - smm_handler_start + SMM_HANDLER_OFFSET), %bx
+	movw	$(smm_gdtptr16 - smm_handler_start + SMM_HANDLER_OFFSET), %bx
 	lgdtl	%cs:(%bx)
 
-	movl    %cr0, %eax
-	andl    $0x7FFAFFD1, %eax /* PG,AM,WP,NE,TS,EM,MP = 0 */
-	orl     $0x60000001, %eax /* CD, NW, PE = 1 */
-	movl    %eax, %cr0
+	movl	%cr0, %eax
+	andl	$0x7FFAFFD1, %eax /* PG,AM,WP,NE,TS,EM,MP = 0 */
+	orl	$0x60000001, %eax /* CD, NW, PE = 1 */
+	movl	%eax, %cr0
 
 	/* Enable protected mode */
 	ljmpl	$0x08, $1f
@@ -124,31 +124,31 @@
 	wbinvd
 
 	/* Use flat data segment */
-	movw    $0x10, %ax
-	movw    %ax, %ds
-	movw    %ax, %es
-	movw    %ax, %ss
-	movw    %ax, %fs
-	movw    %ax, %gs
+	movw	$0x10, %ax
+	movw	%ax, %ds
+	movw	%ax, %es
+	movw	%ax, %ss
+	movw	%ax, %fs
+	movw	%ax, %gs
 
 	/* Get this CPU's LAPIC ID */
-	movl $(LOCAL_APIC_ADDR | LAPIC_ID), %esi
-	movl (%esi), %ecx
-	shr  $24, %ecx
+	movl	$(LOCAL_APIC_ADDR | LAPIC_ID), %esi
+	movl	(%esi), %ecx
+	shr	$24, %ecx
 
 	/* This is an ugly hack, and we should find a way to read the CPU index
 	 * without relying on the LAPIC ID.
 	 */
 #if IS_ENABLED(CONFIG_CPU_AMD_AGESA_FAMILY15_TN)
 	/* LAPIC IDs start from 0x10; map that to the proper core index */
-	subl $0x10, %ecx
+	subl	$0x10, %ecx
 #endif
 
 	/* calculate stack offset by multiplying the APIC ID
 	 * by 1024 (0x400), and save that offset in ebp.
 	 */
-	shl $10, %ecx
-	movl %ecx, %ebp
+	shl	$10, %ecx
+	movl	%ecx, %ebp
 
 	/* We put the stack for each core right above
 	 * its SMM entry point. Core 0 starts at 0xa8000,
@@ -171,13 +171,13 @@
 	movl	%ebx, %esp
 
 	/* Get SMM revision */
-	movl $0xa8000 + 0x7efc, %ebx	/* core 0 address */
-	subl %ebp, %ebx			/* subtract core X offset */
-	movl (%ebx), %eax
-	pushl %eax
+	movl	$0xa8000 + 0x7efc, %ebx	/* core 0 address */
+	subl	%ebp, %ebx		/* subtract core X offset */
+	movl	(%ebx), %eax
+	pushl	%eax
 
 	/* Call 32bit C handler */
-	call smi_handler
+	call	smi_handler
 
 	/* To return, just do rsm. It will "clean up" protected mode */
 	rsm
@@ -227,14 +227,14 @@
 .code16
 jumptable:
 	/* core 3 */
-	ljmp $0xa000, $SMM_HANDLER_OFFSET
+	ljmp	$0xa000, $SMM_HANDLER_OFFSET
 .align 1024, 0x00
 	/* core 2 */
-	ljmp $0xa000, $SMM_HANDLER_OFFSET
+	ljmp	$0xa000, $SMM_HANDLER_OFFSET
 .align 1024, 0x00
 	/* core 1 */
-	ljmp $0xa000, $SMM_HANDLER_OFFSET
+	ljmp	$0xa000, $SMM_HANDLER_OFFSET
 .align 1024, 0x00
 	/* core 0 */
-	ljmp $0xa000, $SMM_HANDLER_OFFSET
+	ljmp	$0xa000, $SMM_HANDLER_OFFSET
 .align 1024, 0x00

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30377
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7a10ddf79cf457b5dde21714b13890fc9510e7ce
Gerrit-Change-Number: 30377
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas at noos.fr>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181222/27e1d5f8/attachment-0001.html>


More information about the coreboot-gerrit mailing list