[coreboot-gerrit] Change in ...coreboot[master]: mb/intel/coffeelake_rvp: Update default configuration

Patrick Georgi (Code Review) gerrit at coreboot.org
Fri Dec 21 19:18:07 CET 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30318 )

Change subject: mb/intel/coffeelake_rvp: Update default configuration
......................................................................

mb/intel/coffeelake_rvp: Update default configuration

Report correct board information for Whiskeylake RVP to OS.
Use short board name like other RVP as it's used
for firmware version check in auto test.

Change-Id: I3f7c95f136e39b978a335cc7855cac819043db7c
Signed-off-by: Wonkyu Kim <wonkyu.kim at intel.com>
Reviewed-on: https://review.coreboot.org/c/30318
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Boon Tiong Teo <boon.tiong.teo at intel.com>
Reviewed-by: Lijian Zhao <lijian.zhao at intel.com>
---
M src/mainboard/intel/coffeelake_rvp/Kconfig
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Lijian Zhao: Looks good to me, approved
  Boon Tiong Teo: Looks good to me, but someone else must approve



diff --git a/src/mainboard/intel/coffeelake_rvp/Kconfig b/src/mainboard/intel/coffeelake_rvp/Kconfig
index 85c8d2f..7597629 100644
--- a/src/mainboard/intel/coffeelake_rvp/Kconfig
+++ b/src/mainboard/intel/coffeelake_rvp/Kconfig
@@ -30,7 +30,8 @@
 
 config MAINBOARD_PART_NUMBER
 	string
-	default "Coffeelake RVP"
+	default "whlrvp" if BOARD_INTEL_WHISKEYLAKE_RVP
+	default "cflrvp"
 
 config MAINBOARD_VENDOR
 	string
@@ -38,7 +39,8 @@
 
 config MAINBOARD_FAMILY
 	string
-	default "Intel_coffeelake_rvp"
+	default "Intel_whlrvp" if BOARD_INTEL_WHISKEYLAKE_RVP
+	default "Intel_cflrvp"
 
 config MAX_CPUS
 	int

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30318
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f7c95f136e39b978a335cc7855cac819043db7c
Gerrit-Change-Number: 30318
Gerrit-PatchSet: 4
Gerrit-Owner: Wonkyu Kim <wonkyu.kim at intel.com>
Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo at intel.com>
Gerrit-Reviewer: Lean Sheng Tan <lean.sheng.tan at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181221/9c8807a2/attachment.html>


More information about the coreboot-gerrit mailing list