[coreboot-gerrit] Change in ...coreboot[master]: src/mainboard/libretrend/lt1000: Initial commit
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Fri Dec 21 12:24:27 CET 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30360 )
Change subject: src/mainboard/libretrend/lt1000: Initial commit
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/30360/1/src/mainboard/libretrend/lt1000/devicetree.cb
File src/mainboard/libretrend/lt1000/devicetree.cb:
https://review.coreboot.org/#/c/30360/1/src/mainboard/libretrend/lt1000/devicetree.cb@298
PS1, Line 298: irq 0xf0 = 0x01
trailing whitespace
https://review.coreboot.org/#/c/30360/1/src/mainboard/libretrend/lt1000/romstage.c
File src/mainboard/libretrend/lt1000/romstage.c:
https://review.coreboot.org/#/c/30360/1/src/mainboard/libretrend/lt1000/romstage.c@36
PS1, Line 36: static const char* get_mainboard_bios_version(void)
"foo* bar" should be "foo *bar"
--
To view, visit https://review.coreboot.org/c/coreboot/+/30360
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32fc8a7d3177ba379d04ad8b87adefcfca2b0fab
Gerrit-Change-Number: 30360
Gerrit-PatchSet: 1
Gerrit-Owner: Michał Żygowski <michal.zygowski at 3mdeb.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski at 3mdeb.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 21 Dec 2018 11:24:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181221/4d1a2f94/attachment.html>
More information about the coreboot-gerrit
mailing list