[coreboot-gerrit] Change in ...coreboot[master]: mb/intel/kblrvp: Change HDA verb table selection logic

Patrick Georgi (Code Review) gerrit at coreboot.org
Thu Dec 20 23:14:16 CET 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30267 )

Change subject: mb/intel/kblrvp: Change HDA verb table selection logic
......................................................................

mb/intel/kblrvp: Change HDA verb table selection logic

All the kaby lake variants uses HDA verb table except RVP8,
hence unselect SOC_INTEL_COMMON_BLOCK_HDA_VERB for RVP8 and
enable for other variants by default.

BUG=None
TEST= Tested on KBL RVP11 and verified the audio functionality.

Signed-off-by: Praveen hodagatta pranesh <praveenx.hodagatta.pranesh at intel.com>
Change-Id: I64d18ab62cfc08b5560dbcf1b77e975eb68c8d30
Reviewed-on: https://review.coreboot.org/c/30267
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Subrata Banik <subrata.banik at intel.com>
Reviewed-by: Boon Tiong Teo <boon.tiong.teo at intel.com>
---
M src/mainboard/intel/kblrvp/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Subrata Banik: Looks good to me, approved
  Boon Tiong Teo: Looks good to me, but someone else must approve



diff --git a/src/mainboard/intel/kblrvp/Kconfig b/src/mainboard/intel/kblrvp/Kconfig
index c0d25a6..0a11dfd 100644
--- a/src/mainboard/intel/kblrvp/Kconfig
+++ b/src/mainboard/intel/kblrvp/Kconfig
@@ -8,7 +8,7 @@
 	select HAVE_ACPI_TABLES
 	select HAVE_OPTION_TABLE
 	select HAVE_SMI_HANDLER
-	select SOC_INTEL_COMMON_BLOCK_HDA_VERB if BOARD_INTEL_KBLRVP3 || BOARD_INTEL_KBLRVP7
+	select SOC_INTEL_COMMON_BLOCK_HDA_VERB if !BOARD_INTEL_KBLRVP8
 	select SOC_INTEL_SKYLAKE
 	select SKYLAKE_SOC_PCH_H if BOARD_INTEL_KBLRVP8
 	select MAINBOARD_USES_FSP2_0

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30267
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64d18ab62cfc08b5560dbcf1b77e975eb68c8d30
Gerrit-Change-Number: 30267
Gerrit-PatchSet: 2
Gerrit-Owner: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh at intel.com>
Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/5d639ad7/attachment.html>


More information about the coreboot-gerrit mailing list