[coreboot-gerrit] Change in ...coreboot[master]: mb/intel/kblrvp: Add helper function to get Board Id

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30306 )

Change subject: mb/intel/kblrvp: Add helper function to get Board Id
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/30306/4/src/mainboard/intel/kblrvp/board_id.h 
File src/mainboard/intel/kblrvp/board_id.h:

https://review.coreboot.org/#/c/30306/4/src/mainboard/intel/kblrvp/board_id.h@22 
PS4, Line 22: #define BOARD_ID_KBL_RVP8	0x42
> BOARD_ID_KBL_RVP8 difine is  used in CL : https://review.coreboot. […]
Yes, it's unrelated to this change. Please define it in 29809 (or any other commit when used the first time).



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/30306
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie20bf0d45a3568c2c433e5b844bea86aac07c47d
Gerrit-Change-Number: 30306
Gerrit-PatchSet: 5
Gerrit-Owner: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh at intel.com>
Gerrit-Reviewer: Boon Tiong Teo <boon.tiong.teo at intel.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Thu, 20 Dec 2018 18:04:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph <siro at das-labor.org>
Comment-In-Reply-To: PraveenX Hodagatta Pranesh <praveenx.hodagatta.pranesh at intel.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/a6ab5892/attachment.html>