[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Program internal SVID/SSID

Lijian Zhao (Code Review) gerrit at coreboot.org
Wed Dec 19 08:13:26 CET 2018


Hello Jairaj Arava, Patrick Rudolph, Pratikkumar V Prajapati, Subrata Banik, Sathyanarayana Nujella, build bot (Jenkins), Krzysztof M Sywula, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/29651

to look at the new patch set (#6).

Change subject: soc/intel/cannonlake: Program internal SVID/SSID
......................................................................

soc/intel/cannonlake: Program internal SVID/SSID

Have an option to let FSP to load default SVID/SSID for internal
devices, and default is disabled. Then it will leave XHCI and HDA
can't get SVID/SSID programmed through pci drivers in coreboot,
the reason is XHCI accordingnd HDA configuration locked in FSP.

Make programming before "lock down" to cover this case.

BUG=b:119058355,b:119054586
TEST=Boot up on Sarien board and check with kernel driver dmesg to see
ALC3204 or ALC3254.

Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488
Signed-off-by: Lijian Zhao <lijian.zhao at intel.com>
---
M src/soc/intel/cannonlake/Kconfig
M src/soc/intel/cannonlake/chip.h
M src/soc/intel/cannonlake/fsp_params.c
3 files changed, 68 insertions(+), 11 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/29651/6
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/29651
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25e22313fd99479f1a2f68636a2eab83126ca488
Gerrit-Change-Number: 29651
Gerrit-PatchSet: 6
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Jairaj Arava <jairaj.arava at intel.com>
Gerrit-Reviewer: Krzysztof M Sywula <krzysztof.m.sywula at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati at intel.com>
Gerrit-Reviewer: Sathyanarayana Nujella <sathyanarayana.nujella at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Duncan Laurie <dlaurie at chromium.org>
Gerrit-CC: Nico Huber <nico.h at gmx.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181219/ab09384c/attachment.html>


More information about the coreboot-gerrit mailing list