[coreboot-gerrit] Change in ...coreboot[master]: drivers/generic/bayhub: Add reset capability
Nico Huber (Code Review)
gerrit at coreboot.org
Thu Dec 20 12:58:55 CET 2018
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30319 )
Change subject: drivers/generic/bayhub: Add reset capability
......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/30319/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/30319/2//COMMIT_MSG@10
PS2, Line 10: set bit 15 of subsystem ID
interesting choice
https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c
File src/drivers/generic/bayhub/bh720.c:
https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c@61
PS2, Line 61: pci_or_config16(dev, PCI_SUBSYSTEM_ID, BH720_EARLY_RESET);
Move into the `if` below so you don't have to clear it in the `else`?
https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c@63
PS2, Line 63: BH720_SOFTWARE_RESET);
I guess this shortcut is fine for the given device (you now exactly that it's a 32-bit memory resource); the generic way would be find_resource().
https://review.coreboot.org/#/c/30319/2/src/drivers/generic/bayhub/bh720.c@91
PS2, Line 91: .init = bh720_init,
This is rather late in ramstage. Might still save enough time, though.
--
To view, visit https://review.coreboot.org/c/coreboot/+/30319
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3878ee782c8da1a28c6d669dd7eceda7c8cf4e5
Gerrit-Change-Number: 30319
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Simon Glass <sjg at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 20 Dec 2018 11:58:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20181220/f570b5a4/attachment.html>
More information about the coreboot-gerrit
mailing list